From: Michal Simek <michal.simek@xilinx.com>
To: Nick Desaulniers <ndesaulniers@google.com>,
Krzysztof Kozlowski <krzk@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
kernel test robot <lkp@intel.com>,
<naga.sureshkumar.relli@xilinx.com>,
Linus Walleij <linus.walleij@linaro.org>,
Michal Simek <michal.simek@xilinx.com>
Subject: Re: [PATCH] memory: pl353-smc: fix compile test on !ARM_AMBA
Date: Fri, 30 Oct 2020 07:59:13 +0100 [thread overview]
Message-ID: <7fd6b14a-6a27-50cf-2232-4c9c00a3b35c@xilinx.com> (raw)
In-Reply-To: <CAKwvOdnKgWN4D0_py00__AaTT+xGK3mjGYPDvBVykw6g=1845A@mail.gmail.com>
On 30. 10. 20 1:40, Nick Desaulniers wrote:
> + authors/reviewers of commit fee10bd22678 ("memory: pl353: Add driver
> for arm pl353 static memory controller")
>
> On Thu, Oct 29, 2020 at 12:34 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>>
>> The pl353-smc driver uses module_amba_driver so it has a build
>> dependency on CONFIG_ARM_AMBA:
>>
>> /usr/bin/arm-linux-gnueabi-ld: drivers/memory/pl353-smc.o: in function `pl353_smc_driver_init':
>> pl353-smc.c:(.init.text+0x10): undefined reference to `amba_driver_register'
>>
>> However it still can be compile tested on platforms other than ARM,
>> which in practice is limited to those selecting ARM_AMBA (so only
>> ARM64).
Indeed.
Acked-by: Michal Simek <michal.simek@xilinx.com>
Thanks,
Michal
prev parent reply other threads:[~2020-10-30 6:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-29 19:33 Krzysztof Kozlowski
2020-10-30 0:40 ` Nick Desaulniers
2020-10-30 6:59 ` Michal Simek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7fd6b14a-6a27-50cf-2232-4c9c00a3b35c@xilinx.com \
--to=michal.simek@xilinx.com \
--cc=krzk@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=naga.sureshkumar.relli@xilinx.com \
--cc=ndesaulniers@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®