From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0E0CC433E0 for ; Fri, 12 Jun 2020 16:46:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A0C3E207ED for ; Fri, 12 Jun 2020 16:46:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=web.de header.i=@web.de header.b="i8zpwaup" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726283AbgFLQqD (ORCPT ); Fri, 12 Jun 2020 12:46:03 -0400 Received: from mout.web.de ([212.227.17.11]:51181 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726085AbgFLQqC (ORCPT ); Fri, 12 Jun 2020 12:46:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1591980358; bh=Aw9hkPbdMQBkc/+yHULSaIXYuk/eH8xPsm5kLkoq2Us=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=i8zpwaupUmgyFaCaVtTLarpdTAEbGO1YenfQ1a4wNswU7YdebNjNBPEvcFcVD6FEa TfN+rkZdvwuwee/dAosnf3bEFOV6yENv+5kUyIYjsYOloFKZAjaJ5x9Mn3Tl41Y+i+ Wc7JxQDii6K32cMVII0jO8ljjtQA2xAQG26eqa8k= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from [192.168.1.2] ([93.131.95.40]) by smtp.web.de (mrweb106 [213.165.67.124]) with ESMTPSA (Nemesis) id 1McZjb-1jDUKp0bSn-00cohi; Fri, 12 Jun 2020 18:45:58 +0200 Subject: Re: [PATCH v2] proc/fd: Remove unnecessary variable initialisations in seq_show() To: Kaitao Cheng , linux-fsdevel@vger.kernel.org Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Alexey Dobriyan , Colin Ian King , Muchun Song References: <20200612160946.21187-1-pilgrimtao@gmail.com> From: Markus Elfring Autocrypt: addr=Markus.Elfring@web.de; prefer-encrypt=mutual; keydata= mQINBFg2+xABEADBJW2hoUoFXVFWTeKbqqif8VjszdMkriilx90WB5c0ddWQX14h6w5bT/A8 +v43YoGpDNyhgA0w9CEhuwfZrE91GocMtjLO67TAc2i2nxMc/FJRDI0OemO4VJ9RwID6ltwt mpVJgXGKkNJ1ey+QOXouzlErVvE2fRh+KXXN1Q7fSmTJlAW9XJYHS3BDHb0uRpymRSX3O+E2 lA87C7R8qAigPDZi6Z7UmwIA83ZMKXQ5stA0lhPyYgQcM7fh7V4ZYhnR0I5/qkUoxKpqaYLp YHBczVP+Zx/zHOM0KQphOMbU7X3c1pmMruoe6ti9uZzqZSLsF+NKXFEPBS665tQr66HJvZvY GMDlntZFAZ6xQvCC1r3MGoxEC1tuEa24vPCC9RZ9wk2sY5Csbva0WwYv3WKRZZBv8eIhGMxs rcpeGShRFyZ/0BYO53wZAPV1pEhGLLxd8eLN/nEWjJE0ejakPC1H/mt5F+yQBJAzz9JzbToU 5jKLu0SugNI18MspJut8AiA1M44CIWrNHXvWsQ+nnBKHDHHYZu7MoXlOmB32ndsfPthR3GSv jN7YD4Ad724H8fhRijmC1+RpuSce7w2JLj5cYj4MlccmNb8YUxsE8brY2WkXQYS8Ivse39MX BE66MQN0r5DQ6oqgoJ4gHIVBUv/ZwgcmUNS5gQkNCFA0dWXznQARAQABtCZNYXJrdXMgRWxm cmluZyA8TWFya3VzLkVsZnJpbmdAd2ViLmRlPokCVAQTAQgAPhYhBHDP0hzibeXjwQ/ITuU9 Figxg9azBQJYNvsQAhsjBQkJZgGABQsJCAcCBhUICQoLAgQWAgMBAh4BAheAAAoJEOU9Figx g9azcyMP/iVihZkZ4VyH3/wlV3nRiXvSreqg+pGPI3c8J6DjP9zvz7QHN35zWM++1yNek7Ar OVXwuKBo18ASlYzZPTFJZwQQdkZSV+atwIzG3US50ZZ4p7VyUuDuQQVVqFlaf6qZOkwHSnk+ CeGxlDz1POSHY17VbJG2CzPuqMfgBtqIU1dODFLpFq4oIAwEOG6fxRa59qbsTLXxyw+PzRaR LIjVOit28raM83Efk07JKow8URb4u1n7k9RGAcnsM5/WMLRbDYjWTx0lJ2WO9zYwPgRykhn2 sOyJVXk9xVESGTwEPbTtfHM+4x0n0gC6GzfTMvwvZ9G6xoM0S4/+lgbaaa9t5tT/PrsvJiob kfqDrPbmSwr2G5mHnSM9M7B+w8odjmQFOwAjfcxoVIHxC4Cl/GAAKsX3KNKTspCHR0Yag78w i8duH/eEd4tB8twcqCi3aCgWoIrhjNS0myusmuA89kAWFFW5z26qNCOefovCx8drdMXQfMYv g5lRk821ZCNBosfRUvcMXoY6lTwHLIDrEfkJQtjxfdTlWQdwr0mM5ye7vd83AManSQwutgpI q+wE8CNY2VN9xAlE7OhcmWXlnAw3MJLW863SXdGlnkA3N+U4BoKQSIToGuXARQ14IMNvfeKX NphLPpUUnUNdfxAHu/S3tPTc/E/oePbHo794dnEm57LuuQINBFg2+xABEADZg/T+4o5qj4cw nd0G5pFy7ACxk28mSrLuva9tyzqPgRZ2bdPiwNXJUvBg1es2u81urekeUvGvnERB/TKekp25 4wU3I2lEhIXj5NVdLc6eU5czZQs4YEZbu1U5iqhhZmKhlLrhLlZv2whLOXRlLwi4jAzXIZAu 76mT813jbczl2dwxFxcT8XRzk9+dwzNTdOg75683uinMgskiiul+dzd6sumdOhRZR7YBT+xC wzfykOgBKnzfFscMwKR0iuHNB+VdEnZw80XGZi4N1ku81DHxmo2HG3icg7CwO1ih2jx8ik0r riIyMhJrTXgR1hF6kQnX7p2mXe6K0s8tQFK0ZZmYpZuGYYsV05OvU8yqrRVL/GYvy4Xgplm3 DuMuC7/A9/BfmxZVEPAS1gW6QQ8vSO4zf60zREKoSNYeiv+tURM2KOEj8tCMZN3k3sNASfoG fMvTvOjT0yzMbJsI1jwLwy5uA2JVdSLoWzBD8awZ2X/eCU9YDZeGuWmxzIHvkuMj8FfX8cK/ 2m437UA877eqmcgiEy/3B7XeHUipOL83gjfq4ETzVmxVswkVvZvR6j2blQVr+MhCZPq83Ota xNB7QptPxJuNRZ49gtT6uQkyGI+2daXqkj/Mot5tKxNKtM1Vbr/3b+AEMA7qLz7QjhgGJcie qp4b0gELjY1Oe9dBAXMiDwARAQABiQI8BBgBCAAmFiEEcM/SHOJt5ePBD8hO5T0WKDGD1rMF Alg2+xACGwwFCQlmAYAACgkQ5T0WKDGD1rOYSw/+P6fYSZjTJDAl9XNfXRjRRyJSfaw6N1pA Ahuu0MIa3djFRuFCrAHUaaFZf5V2iW5xhGnrhDwE1Ksf7tlstSne/G0a+Ef7vhUyeTn6U/0m +/BrsCsBUXhqeNuraGUtaleatQijXfuemUwgB+mE3B0SobE601XLo6MYIhPh8MG32MKO5kOY hB5jzyor7WoN3ETVNQoGgMzPVWIRElwpcXr+yGoTLAOpG7nkAUBBj9n9TPpSdt/npfok9ZfL /Q+ranrxb2Cy4tvOPxeVfR58XveX85ICrW9VHPVq9sJf/a24bMm6+qEg1V/G7u/AM3fM8U2m tdrTqOrfxklZ7beppGKzC1/WLrcr072vrdiN0icyOHQlfWmaPv0pUnW3AwtiMYngT96BevfA qlwaymjPTvH+cTXScnbydfOQW8220JQwykUe+sHRZfAF5TS2YCkQvsyf7vIpSqo/ttDk4+xc Z/wsLiWTgKlih2QYULvW61XU+mWsK8+ZlYUrRMpkauN4CJ5yTpvp+Orcz5KixHQmc5tbkLWf x0n1QFc1xxJhbzN+r9djSGGN/5IBDfUqSANC8cWzHpWaHmSuU3JSAMB/N+yQjIad2ztTckZY pwT6oxng29LzZspTYUEzMz3wK2jQHw+U66qBFk8whA7B2uAU1QdGyPgahLYSOa4XAEGb6wbI FEE= Message-ID: <7fdada40-370d-37b3-3aab-bfbedaa1804f@web.de> Date: Fri, 12 Jun 2020 18:45:57 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: <20200612160946.21187-1-pilgrimtao@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:zjLPVqNL2Dql4xEhEJFbg0DM8T1TMlEL+JWm0v2ZS0sZM02PE/3 /4Au7uOvLvA91ic9z04IUyY5DJjfNcV6wdaZbfLzRAqJ8/2YB+9/6M2+bvKgxpSejEtWpyh fsRTur1hG7+IBYGILsPFyqDtN+i2ay2fRJqBcfvIE5kzAIIzAWIWFqQ2bWMDZtj+YDGD8eg veDYcNuESRJiO4x7PYm5Q== X-UI-Out-Filterresults: notjunk:1;V03:K0:j+bPMn8pyDY=:zlo8f5myloleruoYYMmHtM D/O3ZRZ1I/aqDjKg/o/mwonvCi83j8OLdmD5iWDc5U29ZtN4MYk+l+Dl+reNenueZsyHSYOmb aPeLePFT6wJ5mreYFZ+Q0XfIRUzCuu+FDeQu4qK/WsxxCsfvc0hi9frnINKGdGUUuOVJyYh5w Qf6m0vqvN9O0VWOhIIBu0NMOLcTt1p/V8u+YRmwmAPWUwxyNGihqEb2n4tx69GheSuJhRJweZ cnaR0oXuNgZ5NanvPNbGv/OTqfC+Spjv+S5q44kXj25Jg/DUom5Aqi9La+Djc6IlqgT/ybtVJ GaxIzQcU3RyWjeNPZqaR+Qg19T6VvnMaHIjvcDh1twL018GdgxaQicHyZ9Y033z2YAn2ipnBC axKf/cDl3+lbTlYZvVyOkaFtz+wgrFUGqAHwPDKk96P1XLroe5zhnPb48BqpxEAUm7b1Rafqo HEXi3z3OPEoIShEAcM1oo4EN+VxiOI1nOIJrdlibtrqr/Hv5zkDVq+iN7fTchfRPlI5PnM0jF k37GT05IU972XupDF3TxrNy+e9wjBYK9+u8XqdAus29rb6NTH+MVUnYo1v+OtrA3qaarYM3K7 b/iNiqW+I1E57755oRqBWw+8DpX+vGvt1dCeUV0zEYA+54yUKyFsnsIurlWWf/9JPldC6u+iu s2jnWSvCjO7QAsLlbdLt9mcFF93VvqkXSDwbf4Al3sosJbwWEPPlswaFQvy/J3Fl58wyaG1Mq qxyGAuFJOBa1G5dUG36WbvSLVH6hxbEbtEC1NVTOVhE+60Yi3+DF7IBb0xBi9a+UpRnfFEUH3 kE62BgBLUbH9H/0P01UPkpkULxEIadDlMAFPA8QyibMqKo2QCR4cZegQRsOTYF1op9nNSOVp2 jXMlnsSY8mM5Pu9vk0/9phnM+eU7UuO3DAYLDGKtAxHisg0rOIJjdUYqDQm8RxjQlptD9ReKX 3lj3SpAJ1EuPQ8CsJeWV3zd/qJIDMiObg/MdPTnNQ3iynt5pAxF3lCcNHQYVH0YxTvdU0aPiX uq69lVMQwKy0vTe6RVyFTBiomnv8rGg6rWNAYXMvf78CUz5afMpkZaW4BopBifSrGWRMpuOzT uPEjVkbayf7iG1FMmdHirjXM2r37Flsw80CQJDwM8d8fltjF7R6iOLpsEDEreHrjvnkghXuNb O1JNtpuPF1UXTJkey8XFfa/arWH6c9N4kJ299LT1Z4dk1g9w5XDfvH0ATDNmQK+Qbz1Y9DjN0 cAYkvHvQYTc/lDy5I Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > 'files' will be immediately reassigned. 'f_flags' and 'file' will be > overwritten in the if{} or seq_show() directly exits with an error. > so we don't need to consume CPU resources to initialize them. I suggest to improve also this change description. * Should the mentioned identifiers refer to variables? * Will another imperative wording be preferred? https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/= Documentation/process/submitting-patches.rst?id=3Db791d1bdf9212d944d749a5c= 7ff6febdba241771#n151 * I propose to extend the patch a bit more. How do you think about to convert the initialisation for the variable = =E2=80=9Cret=E2=80=9D also into a later assignment? Regards, Markus