From: "Jiaxun Yang" <jiaxun.yang@flygoat.com>
To: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
Cc: "Thomas Bogendoerfer" <tsbogend@alpha.franken.de>,
"Arnd Bergmann" <arnd@arndb.de>, "Baoquan He" <bhe@redhat.com>,
"linux-mips@vger.kernel.org" <linux-mips@vger.kernel.org>,
linux-kernel@vger.kernel.org,
"stable@vger.kernel.org" <stable@vger.kernel.org>,
"Mateusz Jończyk" <mat.jonczyk@o2.pl>
Subject: Re: [PATCH] MIPS: pci-legacy: Override pci_address_to_pio
Date: Tue, 14 Jan 2025 18:55:53 +0000 [thread overview]
Message-ID: <7fdfbadf-3ed9-4b95-84cc-418cbc9e1997@app.fastmail.com> (raw)
In-Reply-To: <2025011441-mountable-glitch-da1b@gregkh>
在2025年1月14日一月 下午6:46,Greg KH写道:
> On Tue, Jan 14, 2025 at 06:11:58PM +0000, Jiaxun Yang wrote:
>> pci-legacy systems are not using logic_pio to managed PIO
>> allocations, thus the generic pci_address_to_pio won't work
>> when PCI_IOBASE is defined.
>>
>> Override the function to use architecture implementation to
>> fix the problem.
>>
>> Cc: stable@vger.kernel.org
>> Fixes: 4bfb53e7d317 ("mips: add <asm-generic/io.h> including")
>> Reported-by: Mateusz Jończyk <mat.jonczyk@o2.pl>
>> Closes: https://lore.kernel.org/r/99f75c66-4c2d-45dc-a808-b5ba440c7551@app.fastmail.com/
>> Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
>> ---
>> This is a quick fix for fixes tree and stable backporting.
>> In long term, we should get logic_pio accept fixed mapping,
>> and make PCI core code aware of platforms not using vmap
>> for PCI_IOBASE.
>
> Why not do the real work now. Don't worry about stable kernels, fix it
> properly.
:-( Sadly the long-term solution is going to be a huge effort across
architectures, and I'm not even sure if people will agree with my approach.
So I'd prefer get this fix applied first and kick up discussions on a
long-term solution.
Will post RFC shortly.
Thanks
>
> thanks,
>
> greg k-h
--
- Jiaxun
next prev parent reply other threads:[~2025-01-14 18:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-14 18:11 Jiaxun Yang
2025-01-14 18:42 ` Mateusz Jończyk
2025-01-14 18:51 ` Jiaxun Yang
2025-01-19 11:42 ` Mateusz Jończyk
2025-01-14 18:46 ` Greg KH
2025-01-14 18:55 ` Jiaxun Yang [this message]
2025-01-14 19:03 ` Arnd Bergmann
2025-01-14 19:20 ` Jiaxun Yang
2025-01-15 7:38 ` Arnd Bergmann
2025-01-15 8:57 ` Maciej W. Rozycki
2025-01-15 9:26 ` Jiaxun Yang
2025-01-20 19:41 ` Thomas Bogendoerfer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7fdfbadf-3ed9-4b95-84cc-418cbc9e1997@app.fastmail.com \
--to=jiaxun.yang@flygoat.com \
--cc=arnd@arndb.de \
--cc=bhe@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=mat.jonczyk@o2.pl \
--cc=stable@vger.kernel.org \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome