From: "Jürgen Groß" <jgross@suse.com>
To: Nicholas Tsirakis <niko.tsirakis@gmail.com>, boris.ostrovsky@oracle.com
Cc: xen-devel <xen-devel@lists.xenproject.org>, linux-kernel@vger.kernel.org
Subject: Re: [BUG] Xen-ballooned memory never returned to domain after partial-free
Date: Thu, 12 Dec 2019 15:21:14 +0100 [thread overview]
Message-ID: <7feb44ef-0957-3df1-3411-2a7b971d8931@suse.com> (raw)
In-Reply-To: <CAFqpmVLnHPUZEpvmw1-f=2LoPkfUHO67ETdwtnsPA7DsXRSRSA@mail.gmail.com>
On 12.12.19 15:10, Nicholas Tsirakis wrote:
>> And I think this is the problem. We want here:
>>
>> balloon_stats.target_pages = balloon_stats.current_pages +
>> balloon_stats.target_unpopulated;
>
> Ahh I knew I was missing something. Tested the patch, works great! "Reported by"
> is fine with me.
Thanks.
>
> Do you happen to know the answer to my second question? It's not as important,
> but it does confuse me as I wouldn't expect the total memory to be
> balloon-able at
> all with the hotplugging configs disabled.
Ballooning != hotplugging memory
With memory hotplug you can add (or - in theory - remove) memory to the
kernel it didn't know about before.
With ballooning you just give some memory back to the hypervisor, but
kernel still has some knowledge about it (e.g. keeps struct page for
each ballooned memory page).
HTH, Juergen
next prev parent reply other threads:[~2019-12-12 14:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-11 22:08 Nicholas Tsirakis
2019-12-12 7:18 ` Jürgen Groß
2019-12-12 14:10 ` Nicholas Tsirakis
2019-12-12 14:21 ` Jürgen Groß [this message]
2019-12-12 14:30 ` Nicholas Tsirakis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7feb44ef-0957-3df1-3411-2a7b971d8931@suse.com \
--to=jgross@suse.com \
--cc=boris.ostrovsky@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=niko.tsirakis@gmail.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®