From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: Abhinav Kumar <quic_abhinavk@quicinc.com>,
freedreno@lists.freedesktop.org, Rob Clark <robdclark@gmail.com>,
Sean Paul <sean@poorly.run>,
Marijn Suijten <marijn.suijten@somainline.org>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>
Cc: dri-devel@lists.freedesktop.org, quic_jesszhan@quicinc.com,
andersson@kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 2/4] drm/msm/dpu: use dpu core's major version to enable data compress
Date: Wed, 12 Jul 2023 03:37:29 +0300 [thread overview]
Message-ID: <7fecc1b5-0c06-fae2-bced-990006c02fcc@linaro.org> (raw)
In-Reply-To: <20230712003310.31961-3-quic_abhinavk@quicinc.com>
On 12/07/2023 03:33, Abhinav Kumar wrote:
> Instead of using a feature bit to decide whether to enable data
> compress or not for DSC use-cases, use dpu core's major version
> instead by assigning the enable_compression op based on the
> dpu core's major version.
>
> To make this possible pass the struct dpu_mdss_version to
> dpu_hw_intf_init().
>
> This will avoid defining feature bits for every bit level details of
> registers.
>
> changes in v4:
> - split renaming of enable_compression into another change
> - pass struct dpu_mdss_version to dpu_hw_intf_init() to
> assign the enable_compression op based on dpu's core revision
>
> Signed-off-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
> ---
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.c | 8 ++++----
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.h | 3 ++-
> drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c | 2 +-
> 3 files changed, 7 insertions(+), 6 deletions(-)
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
--
With best wishes
Dmitry
next prev parent reply other threads:[~2023-07-12 0:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230712003310.31961-1-quic_abhinavk@quicinc.com>
2023-07-12 0:33 ` [PATCH v4 1/4] drm/msm/dpu: re-introduce dpu core revision to the catalog Abhinav Kumar
2023-07-12 0:36 ` Dmitry Baryshkov
2023-07-12 0:33 ` [PATCH v4 2/4] drm/msm/dpu: use dpu core's major version to enable data compress Abhinav Kumar
2023-07-12 0:37 ` Dmitry Baryshkov [this message]
2023-07-12 0:33 ` [PATCH v4 3/4] drm/msm/dpu: rename enable_compression() to program_intf_cmd_cfg() Abhinav Kumar
2023-07-12 0:42 ` Dmitry Baryshkov
2023-07-12 0:49 ` Abhinav Kumar
2023-07-12 0:33 ` [PATCH v4 4/4] drm/msm/dpu: drop DPU_INTF_DATA_COMPRESS from dpu catalog Abhinav Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7fecc1b5-0c06-fae2-bced-990006c02fcc@linaro.org \
--to=dmitry.baryshkov@linaro.org \
--cc=airlied@gmail.com \
--cc=andersson@kernel.org \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=quic_abhinavk@quicinc.com \
--cc=quic_jesszhan@quicinc.com \
--cc=robdclark@gmail.com \
--cc=sean@poorly.run \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®