From: Mark Brown <broonie@kernel.org>
To: Richard Fitzgerald <rf@opensource.cirrus.com>
Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
patches@opensource.cirrus.com
Subject: Re: [PATCH v3] ASoC: cs35l56: Fix probe deadlock waiting for SoundWire enumeration
Date: Tue, 1 Sep 2026 16:18:35 +0100 [thread overview]
Message-ID: <7feebecc-66f7-4ac2-8c1f-0b8bf55cb528@sirena.org.uk> (raw)
In-Reply-To: <20260901122644.634494-1-rf@opensource.cirrus.com>
[-- Attachment #1: Type: text/plain, Size: 810 bytes --]
On Tue, Sep 01, 2026 at 01:26:44PM +0100, Richard Fitzgerald wrote:
> The work item is queued on a freezable workqueue to prevent a race between
> the work item and system_suspend of another instance. If the workqueue
> were not frozen it would be possible for the work item of one driver
> instance to call snd_soc_register_component() which then calls
> cs35l56_component_probe() of another instance while that instance is
> already executing its system suspend functions.
I'll apply this since it's very much a corner case and there's a real
problem but you should probably check out the kexec case - it looks like
it misses freeze_kernel_threads(). TBH I'm not sure the issue there
isn't on the kexec side, it's not exactly a common case and having a
difference like that feels like asking for trouble.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2026-09-01 15:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-01 12:26 Richard Fitzgerald
2026-09-01 15:18 ` Mark Brown [this message]
2026-09-01 15:38 ` Richard Fitzgerald
2026-09-01 15:48 ` Mark Brown
2026-09-01 15:50 ` Richard Fitzgerald
2026-09-01 15:21 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7feebecc-66f7-4ac2-8c1f-0b8bf55cb528@sirena.org.uk \
--to=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=rf@opensource.cirrus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®