From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 76A5047F4A for ; Mon, 20 Jan 2025 08:01:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737360109; cv=none; b=ku3ueaVnNF/ciOWSf9t699yG9zkNDSisNwADrTaCbCzpKPZaFYxEFdLbukF8dKi1lbpjVjqlJTtFkGtpYsSra/7Gkucqiq5CadgqvD/RszszPvukVeFJusrZHdwKBnY8yqN06OvfpSNebEVnzPVgLQlOBgygMNE1fOATywW1EwI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737360109; c=relaxed/simple; bh=wSwcgSkuSB+5eIMnEtCS4Y+X3PAmOe4c1b+T7ftukoE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=hNyWTvsXakfDPK1hVG8631UskqfF3pG5RYHSUO0xgBnPeemsQ9Od6wePXd+wRtBs6mgBQTl46H9D97vKzwAOCumpfhMpRD91VqZgcDzTneCWIS4W4GBNshZ0/jibpZAbWm4+vlEGpWyIkN5hhYaxl4Z1/EPgNho3VxiXRUbDBDs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=dvqzJdny; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="dvqzJdny" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1737360106; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=oAIRsvy1iUN7K40ZcLKVA2dIBS5NYMarhwQ6Yyq1d0k=; b=dvqzJdnys7e2Ltbvnkl7Z82O/3+2vmFUpS4mYdMIiII/D2vVxuW2z7wHlfWDY482rfmlew fa01A4HQCx6GtfeH4lZVa6WUmhyXKBmbTb/HQqbwEcpNq/2wqySCNPMncO30YGWxuYUEu4 L546jgLhjZgTVqWIMswXyRP2P8vvrxU= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-687-MKVQCalwOeiwmLXoeVlAhQ-1; Mon, 20 Jan 2025 03:01:44 -0500 X-MC-Unique: MKVQCalwOeiwmLXoeVlAhQ-1 X-Mimecast-MFC-AGG-ID: MKVQCalwOeiwmLXoeVlAhQ Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-43673af80a6so32699635e9.1 for ; Mon, 20 Jan 2025 00:01:44 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737360104; x=1737964904; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=oAIRsvy1iUN7K40ZcLKVA2dIBS5NYMarhwQ6Yyq1d0k=; b=S633Oz43D7QryBGNTGmCMhgJPib539/JdGIxRvapZuOfcCvwgGOK5eiHao+xxLk74b wGorpe3Y1h1rpy0hmoe2u4xKS0CuDglk197zcpoyjLXcYL0UMfp/nCbSvQhz4jeQNHSa WPhtevPIsLlj68k5Yqetg+ZzSxBCIAJdbS+nKjjhvRbkToBQa7eL6+O2FVBdCjvnye0r wcDBSxLBpmJ3mGLw4h02EjQygXnX7TWRpreHvGTr8fgnQp37kmJsW5iieCds+0pCdXMT 7NlvmkWnmVkSjamY2euzDlWLjW7KK1T/UbuEBGeRiYMRbCviyon2QSbmIixF59MvImlX WwGA== X-Forwarded-Encrypted: i=1; AJvYcCVdp0+44yXBzPD3dinSuirPCE8cjePo6GQKs91H+g8Q7u2aF8soua0LxOcnKABwGpICBNWy2apDRhQvopQ=@vger.kernel.org X-Gm-Message-State: AOJu0YyyxcSsz8wHGPshNj8UZJKnkV6r0W/MMJDnWF158Ark52eiU/GC eYuBMkmHiaqREZW99qYfzu/IFXBlYEely/l2E6I+6yUH1SxUCPzIBrmndXb+LRkrFsNmNZpBrxZ E9HVoxZuYCxg1z0/f7wqdb9UaBehLmmJKq4h9Boea17Qtq58wsTvlBqa+3cy+yw== X-Gm-Gg: ASbGncuGrm0v40fjH9iVd6+UJ/Opw3jpdpwqYQ620vBUq/ID7JWIbosCPz2QAJXBA/j Ai/WLfwtPbePUm6ok49vK6qDU64GSt2mk+kg+z2v3jWb1V/ZwcS7kyHv12XqWsIOsYzN+D1BLsY ttKcIoy8SrlNVghqhOQjs0ZvQYn0Kd3vl6AwtfD+UEZMB4PfoxFVy7AaDFJXPlac4ba+rByqx0w H2SFyVCL4100flKl5aX2Ligw1+XtMmi4rrV4AMSbMfOM323+RxG9DSCTx3N24NZA422OD4MHS90 M+gsbRoRzGohzDptd68MvqLXF6P1I1+TQsuc6iJaf6Gcl6djGOLawjXQRW/i683RQr7h2NML4lY JPVs+Dxmmmiyg30aPKFzRJA== X-Received: by 2002:a05:600c:511b:b0:435:14d:f61a with SMTP id 5b1f17b1804b1-438914304a8mr86102975e9.25.1737360103694; Mon, 20 Jan 2025 00:01:43 -0800 (PST) X-Google-Smtp-Source: AGHT+IEGItrWD7l1yNqxMY5Fi8U946POGbmMAEin3xvpeHKPy4F0M1/pIsuwk2TAGMjmRbXgLp80Dg== X-Received: by 2002:a05:600c:511b:b0:435:14d:f61a with SMTP id 5b1f17b1804b1-438914304a8mr86102705e9.25.1737360103322; Mon, 20 Jan 2025 00:01:43 -0800 (PST) Received: from ?IPV6:2003:d8:2f22:1000:d72d:fd5f:4118:c70b? (p200300d82f221000d72dfd5f4118c70b.dip0.t-ipconnect.de. [2003:d8:2f22:1000:d72d:fd5f:4118:c70b]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-437c73e7140sm191722745e9.0.2025.01.20.00.01.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Jan 2025 00:01:42 -0800 (PST) Message-ID: <7ff8de59-f91e-4d39-8b6a-2f135b2a2397@redhat.com> Date: Mon, 20 Jan 2025 09:01:41 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/3] mm: memory-hotplug: check folio ref count first in do_migrate_rang To: Wupeng Ma , akpm@linux-foundation.org, osalvador@suse.de, nao.horiguchi@gmail.com, linmiaohe@huawei.com, mhocko@suse.com Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20250116061657.227027-1-mawupeng1@huawei.com> <20250116061657.227027-4-mawupeng1@huawei.com> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250116061657.227027-4-mawupeng1@huawei.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 16.01.25 07:16, Wupeng Ma wrote: > From: Ma Wupeng > > If a folio has an increased reference count, folio_try_get() will acquire > it, perform necessary operations, and then release it. In the case of a > poisoned folio without an elevated reference count (which is unlikely for > memory-failure), folio_try_get() will simply bypass it. > > Therefore, relocate the folio_try_get() function, responsible for checking > and acquiring this reference count at first. > > Signed-off-by: Ma Wupeng > --- > mm/memory_hotplug.c | 14 ++++---------- > 1 file changed, 4 insertions(+), 10 deletions(-) > > diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c > index 2815bd4ea483..3fb75ee185c6 100644 > --- a/mm/memory_hotplug.c > +++ b/mm/memory_hotplug.c > @@ -1786,6 +1786,9 @@ static void do_migrate_range(unsigned long start_pfn, unsigned long end_pfn) > page = pfn_to_page(pfn); > folio = page_folio(page); > > + if (!folio_try_get(folio)) > + continue; > + I would only move it in front of the folio_test_hwpoison() check for now. Note that with this patch as is the comment below would be wrong > /* > * No reference or lock is held on the folio, so it might ^ I would move this patch before the current #2, so the folio_lock() looks less weird. -- Cheers, David / dhildenb