mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Ard Biesheuvel" <ardb@kernel.org>
To: "Eric Biggers" <ebiggers@kernel.org>, linux-kernel@vger.kernel.org
Cc: linux-crypto@vger.kernel.org
Subject: Re: [PATCH] crypto: crc32c - Remove another outdated comment
Date: Tue, 17 Mar 2026 12:10:27 +0100	[thread overview]
Message-ID: <7ffbc472-69a3-4350-a19f-1349650ae4da@app.fastmail.com> (raw)
In-Reply-To: <20260316205659.17936-1-ebiggers@kernel.org>



On Mon, 16 Mar 2026, at 21:56, Eric Biggers wrote:
> This code just calls crc32c(), which has a number of different
> implementations, not just the byte-at-a-time table-based one.
>
> Signed-off-by: Eric Biggers <ebiggers@kernel.org>
> ---
>
> This patch is targeting crc-next
>
>  crypto/crc32c.c | 5 -----
>  1 file changed, 5 deletions(-)
>

Acked-by: Ard Biesheuvel <ardb@kernel.org>

> diff --git a/crypto/crc32c.c b/crypto/crc32c.c
> index 1eff54dde2f7..3754985ab948 100644
> --- a/crypto/crc32c.c
> +++ b/crypto/crc32c.c
> @@ -47,15 +47,10 @@ struct chksum_ctx {
> 
>  struct chksum_desc_ctx {
>  	u32 crc;
>  };
> 
> -/*
> - * Steps through buffer one byte at a time, calculates reflected
> - * crc using table.
> - */
> -
>  static int chksum_init(struct shash_desc *desc)
>  {
>  	struct chksum_ctx *mctx = crypto_shash_ctx(desc->tfm);
>  	struct chksum_desc_ctx *ctx = shash_desc_ctx(desc);
> 
>
> base-commit: c13cee2fc7f137dd25ed50c63eddcc578624f204
> -- 
> 2.53.0

  reply	other threads:[~2026-03-17 11:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-16 20:56 Eric Biggers
2026-03-17 11:10 ` Ard Biesheuvel [this message]
2026-03-17 16:30 ` Eric Biggers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7ffbc472-69a3-4350-a19f-1349650ae4da@app.fastmail.com \
    --to=ardb@kernel.org \
    --cc=ebiggers@kernel.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®