mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: dongli.zhang@oracle.com
To: linux-block@vger.kernel.org
Cc: axboe@kernel.dk, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] null_blk: remove unused 'll_list' in 'nullb_cmd'
Date: Mon, 24 Feb 2020 09:43:45 -0800	[thread overview]
Message-ID: <7ffcc2b3-c536-91c8-0836-1a8937cf80d8@oracle.com> (raw)
In-Reply-To: <20200224172451.21320-1-dongli.zhang@oracle.com>

nullb_cmd->list is no longer used as well. I would send v2.

Dongli Zhang

On 2/24/20 9:24 AM, Dongli Zhang wrote:
> The 'll_list' is no longer used since commit 3c395a969acc ("null_blk: set a
> separate timer for each command").
> 
> Signed-off-by: Dongli Zhang <dongli.zhang@oracle.com>
> ---
>  drivers/block/null_blk.h      | 1 -
>  drivers/block/null_blk_main.c | 1 -
>  2 files changed, 2 deletions(-)
> 
> diff --git a/drivers/block/null_blk.h b/drivers/block/null_blk.h
> index bc837862b767..34fec8814bf1 100644
> --- a/drivers/block/null_blk.h
> +++ b/drivers/block/null_blk.h
> @@ -15,7 +15,6 @@
>  
>  struct nullb_cmd {
>  	struct list_head list;
> -	struct llist_node ll_list;
>  	struct __call_single_data csd;
>  	struct request *rq;
>  	struct bio *bio;
> diff --git a/drivers/block/null_blk_main.c b/drivers/block/null_blk_main.c
> index 16510795e377..07301c72b102 100644
> --- a/drivers/block/null_blk_main.c
> +++ b/drivers/block/null_blk_main.c
> @@ -1519,7 +1519,6 @@ static int setup_commands(struct nullb_queue *nq)
>  	for (i = 0; i < nq->queue_depth; i++) {
>  		cmd = &nq->cmds[i];
>  		INIT_LIST_HEAD(&cmd->list);
> -		cmd->ll_list.next = NULL;
>  		cmd->tag = -1U;
>  	}
>  
> 

      reply	other threads:[~2020-02-24 17:45 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-24 17:24 Dongli Zhang
2020-02-24 17:43 ` dongli.zhang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7ffcc2b3-c536-91c8-0836-1a8937cf80d8@oracle.com \
    --to=dongli.zhang@oracle.com \
    --cc=axboe@kernel.dk \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®