From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751035AbdFHH47 (ORCPT <rfc822;w@1wt.eu>);
        Thu, 8 Jun 2017 03:56:59 -0400
Received: from mx2.suse.de ([195.135.220.15]:35183 "EHLO mx1.suse.de"
        rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
        id S1751787AbdFHHzj (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 8 Jun 2017 03:55:39 -0400
Subject: Re: [PATCH v6 05/10] nvmet: implement namespace identify descriptor
 list
To: Christoph Hellwig <hch@lst.de>
Cc: Sagi Grimberg <sagi@grimberg.me>, Keith Busch <keith.busch@intel.com>,
        Hannes Reinecke <hare@suse.de>, Max Gurtovoy <maxg@mellanox.com>,
        Linux NVMe Mailinglist <linux-nvme@lists.infradead.org>,
        Linux Kernel Mailinglist <linux-kernel@vger.kernel.org>
References: <20170607094536.32419-1-jthumshirn@suse.de>
 <20170607094536.32419-6-jthumshirn@suse.de> <20170608074414.GD13953@lst.de>
 <ac55e56a-a47e-1e53-c537-b940de99c746@suse.de>
 <20170608075209.GA14359@lst.de>
From: Johannes Thumshirn <jthumshirn@suse.de>
Message-ID: <7ffdc123-c43b-dff0-73bf-4e876ece323e@suse.de>
Date: Thu, 8 Jun 2017 09:55:37 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.1.1
MIME-Version: 1.0
In-Reply-To: <20170608075209.GA14359@lst.de>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 06/08/2017 09:52 AM, Christoph Hellwig wrote:
> On Thu, Jun 08, 2017 at 09:49:35AM +0200, Johannes Thumshirn wrote:
>> On 06/08/2017 09:44 AM, Christoph Hellwig wrote:
>>>> +	if (sg_zeroout_area(req->sg, req->sg_cnt, NVME_IDENTIFY_DATA_SIZE, off)
>>>
>>> Shouldn;t the third argument be NVME_IDENTIFY_DATA_SIZE - off in theory?
>>> It's probably fine as is as the S/G helpers deal with overflows
>>> gracefully, but still..
>>
>> Ahm yes. *doh*
>>
>> Can you fix it up when applying?
> 
> Sure.
> 

Btw, is the NVMf sleftests still avtively developed? If yes I have a
testcase for this series (not sure this qualifies for blktests)

-- 
Johannes Thumshirn                                          Storage
jthumshirn@suse.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850