From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5383FC433B4 for ; Mon, 3 May 2021 23:57:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2C4156135F for ; Mon, 3 May 2021 23:57:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229662AbhECX6M (ORCPT ); Mon, 3 May 2021 19:58:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35426 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229497AbhECX6L (ORCPT ); Mon, 3 May 2021 19:58:11 -0400 Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3A152C061574 for ; Mon, 3 May 2021 16:57:17 -0700 (PDT) Received: by mail-wm1-x336.google.com with SMTP id o127so174420wmo.4 for ; Mon, 03 May 2021 16:57:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=RTrhwe5FlqMxAXLpGz6FP3pMNfP7DO0JlS/VtPEMG74=; b=OY1GqMrdXwXrnAuXBTPr8YH2MPvErnn0sAltbHEyap7pDnJekaXQOqHbGBdfm0RmTC 6lrbrm1e8bB27RkTSrQwqflaQuijdIRWiTrYNSXGkdM5JCYyqZ4EcvpSTZlZQW/daRSE kvncir60eNNRthz++TvIxP8bZjVdylGQlR8cDFxgIfe/kgIjzRjgNUZNiZW6ZecvgUAB Q9fDdzkrWXVqblYfvjxyvNwuAiAWK/VqmVU2mInJer6EsufZ3Zj5yIMFZeMon7DiZvPh smhmClp5QXg53UJHwbbucyPhi5mj2VxExty0pJqxLAXoKTsjfnlHbBr+fvnRKTg6RJAk k20w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=RTrhwe5FlqMxAXLpGz6FP3pMNfP7DO0JlS/VtPEMG74=; b=GKC17IWmj4q5vpAgUqno++IeYEsfw4EhAv1lHTkS+rWe0cDErwe7768n0XEZfSrGBS qa0Vr7xp3Cm6CZ++jO85Tg2BBOQTGJra2keAQRVyKHgqRzI7dhREahKA9Loll4V/QJ85 SIYIARzdW9VibpJKxn33KO6xrtNPwEv/oHhSeTSjRku2Crtx+xdtAj8Jfv4CA1Rgfu7M 5Ub0aalf/suNMI8fpckpBMn1Mc1F7QcOtGfqUA7JHG1bSeyDXEV0dxnZD62QIUxktYio S4Ivla0xBn+XNQE7dNaJQk2NRoajlhjn66RtTmsev/ZJf3wtpVuOdW/r1I0TL7PqnSJV /GxQ== X-Gm-Message-State: AOAM5302m2C2ip15Zgr6q3yOpMa9Ra7A2WKkJfbL4O8I4ChAR45DEZ3U o1KhDVoT3bO058ZqpBQc6JES/w== X-Google-Smtp-Source: ABdhPJwOb2mcyPA4UP5yR/4VuPO7Gv/UDWC/a9zIVAp438kCOwtM4TxMYEhupEG0lyY2Us6CEfsRFg== X-Received: by 2002:a05:600c:3388:: with SMTP id o8mr1025054wmp.101.1620086235839; Mon, 03 May 2021 16:57:15 -0700 (PDT) Received: from localhost (c-71-197-186-152.hsd1.wa.comcast.net. [71.197.186.152]) by smtp.gmail.com with ESMTPSA id l14sm14048582wrv.94.2021.05.03.16.57.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 May 2021 16:57:15 -0700 (PDT) From: Kevin Hilman To: Martin Blumenstingl , narmstrong@baylibre.com, linux-amlogic@lists.infradead.org Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org, Martin Blumenstingl , Stefan Agner Subject: Re: [PATCH RFC] soc: amlogic: meson-ee-pwrc: Drop the .shutdown callback from the driver In-Reply-To: <20210429203723.1177082-1-martin.blumenstingl@googlemail.com> References: <20210429203723.1177082-1-martin.blumenstingl@googlemail.com> Date: Mon, 03 May 2021 16:57:12 -0700 Message-ID: <7h4kfjpe07.fsf@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Martin Blumenstingl writes: > Stefan reports that rebooting his ODROID-N2+ (using a G12B SoC) results > in the board hanging. His kernel config uses: > CONFIG_MESON_EE_PM_DOMAINS=y > CONFIG_DRM_MESON=m > > He reports that his kernel config results in the DRM driver's .shutdown > callback to be executed after the power domain driver's .shutdown > callback. That's problematic because meson_ee_pwrc_shutdown disables the > clock which are used by the VPU IP. This causes the board to hang. I didn't dig deeply on this yet because this smells very much like an issue Art reported[1] and fixed. What kernel version are you using, and does it contain commit fa0c16caf3d7 (drm: meson_drv add shutdown function) Kevin [1] https://lore.kernel.org/dri-devel/20210302042202.3728113-1-art@khadas.com/