From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965506AbcJTQXH (ORCPT ); Thu, 20 Oct 2016 12:23:07 -0400 Received: from mail-pf0-f181.google.com ([209.85.192.181]:33580 "EHLO mail-pf0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756001AbcJTQXF (ORCPT ); Thu, 20 Oct 2016 12:23:05 -0400 From: Kevin Hilman To: Javier Martinez Canillas Cc: linux-kernel@vger.kernel.org, Guenter Roeck , linux-watchdog@vger.kernel.org, Wim Van Sebroeck , Carlo Caione , linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] watchdog: meson: Remove unneeded platform MODULE_ALIAS Organization: BayLibre References: <1476906582-14241-1-git-send-email-javier@osg.samsung.com> Date: Thu, 20 Oct 2016 09:23:03 -0700 In-Reply-To: <1476906582-14241-1-git-send-email-javier@osg.samsung.com> (Javier Martinez Canillas's message of "Wed, 19 Oct 2016 16:49:42 -0300") Message-ID: <7hd1iv7zx4.fsf@baylibre.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Javier Martinez Canillas writes: > The Amlogic Meson is a DT-only platform, which means the devices are > registered via OF and not using the legacy platform devices support. > > So there's no need to have a MODULE_ALIAS("platform:meson-gxbb-wdt") > since the reported uevent MODALIAS to user-space will be the OF one. > > Signed-off-by: Javier Martinez Canillas Acked-by: Kevin Hilman > --- > > drivers/watchdog/meson_gxbb_wdt.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/watchdog/meson_gxbb_wdt.c b/drivers/watchdog/meson_gxbb_wdt.c > index 44d180a2c5e5..45d47664a00a 100644 > --- a/drivers/watchdog/meson_gxbb_wdt.c > +++ b/drivers/watchdog/meson_gxbb_wdt.c > @@ -264,7 +264,6 @@ static struct platform_driver meson_gxbb_wdt_driver = { > > module_platform_driver(meson_gxbb_wdt_driver); > > -MODULE_ALIAS("platform:meson-gxbb-wdt"); > MODULE_AUTHOR("Neil Armstrong "); > MODULE_DESCRIPTION("Amlogic Meson GXBB Watchdog timer driver"); > MODULE_LICENSE("Dual BSD/GPL");