From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49FBCC433EF for ; Wed, 9 Feb 2022 20:31:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231696AbiBIUa7 (ORCPT ); Wed, 9 Feb 2022 15:30:59 -0500 Received: from gmail-smtp-in.l.google.com ([23.128.96.19]:59944 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229946AbiBIUaz (ORCPT ); Wed, 9 Feb 2022 15:30:55 -0500 Received: from mail-pf1-x42f.google.com (mail-pf1-x42f.google.com [IPv6:2607:f8b0:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 14265C002B5D for ; Wed, 9 Feb 2022 12:30:57 -0800 (PST) Received: by mail-pf1-x42f.google.com with SMTP id r19so6370730pfh.6 for ; Wed, 09 Feb 2022 12:30:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=H8UvkuaPa9oG6MBcN88+EFcgU6RwUy+XLZ3L+fuvwWs=; b=jLSqHONTNlyEU0X36UjWm1OP1joipm2nCVWebcdjjAetYBRag2vvSJpPamuNKix4yP rwNNjw1RlAYXs2IL0B2gDrPemV4PSFexAl7LW4k/P83PpiO5dN+gxwb4Sgv+8t56Fa5i 8JaSKqWn+o/nkY2XIM+I2sBbvBFeL1MGcxdBNvYaOCU8YMQqtKpPPXc2VZmdawXxmy0S LJ2iCFCbGYdY+JVuIDZGIZ4SWKk7VLbnBFMyEooeL2WFWVKf30pucY+hBWoZcYcfTvor 296JPhFbIryEeulXN9SjrmIFNcQXBZf5goMqiW0G/5tE7Fu0gUSt4OOfY/492CjnIkzh IyQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=H8UvkuaPa9oG6MBcN88+EFcgU6RwUy+XLZ3L+fuvwWs=; b=yFGbVNJX492p5KuP/25CZJVfKX+mZZXXcH7W2ne5jx57SSLmF8F8UZIm5l2f9Aivvr 7Jxb/jWOCjhhu/79AM4/5vHcuPuA8FDxvbuglcJ8fcqGFCHHh43g9rtFIYiccHYwMs8n cHzEXDzgaI/FaFsQNAm1D7fHMY1A6TeeiM1z8oiEgiRLU5uyxaP4kQGwW/yYeqojaPM0 aNt30N3yXJL7C7bjDzZUOQLOVo4iCX6Go35HpE2kbD5/nqWHVhRk5i0F3FcF5D33e0io LatRDEY5PaVXDZJPf5bainAn7qGfgnO2uFRX2otPYruPjpl3YUoWiM8XDe4j9q/YL4Kj tOWg== X-Gm-Message-State: AOAM532A0tjcACgL8BHovDOkUb9Tebwo3DVranQPynqGiXnqqjicdFYr 3PNLdp6cye3ccOqINx2XA61ahlCFwVv4AQ== X-Google-Smtp-Source: ABdhPJy424vIOl7jQpbzE1qFJbQKb1wuakkXY166U9x9NY98U7JPd35QgGjJclqbpBouDlTQZCmKtQ== X-Received: by 2002:a63:844a:: with SMTP id k71mr3226964pgd.559.1644438656578; Wed, 09 Feb 2022 12:30:56 -0800 (PST) Received: from localhost (c-71-197-186-152.hsd1.wa.comcast.net. [71.197.186.152]) by smtp.gmail.com with ESMTPSA id d10sm20577340pfl.16.2022.02.09.12.30.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Feb 2022 12:30:55 -0800 (PST) From: Kevin Hilman To: "shunzhou.jiang@amlogic.com" , linux-arm-kernel , linux-amlogic , linux-kernel Cc: Neil Armstrong , jbrunet , Martin Blumenstingl , "jianxin.pan" Subject: Re: Re: [PATCH 2/2] soc: s4: Add support for power domains controller In-Reply-To: <202202091001287547451@amlogic.com> References: <20220126061018.705338-1-shunzhou.jiang@amlogic.com> <20220126061018.705338-3-shunzhou.jiang@amlogic.com> <7hzgnal5yu.fsf@baylibre.com> <202202091001287547451@amlogic.com> Date: Wed, 09 Feb 2022 12:30:55 -0800 Message-ID: <7hee4bok8w.fsf@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org "shunzhou.jiang@amlogic.com" writes: > Hi Kevin: > Thanks your reply. > Please refer to below comment, >> S4_VPU_HDMI: for vpu domain, this domain provide power to many moudles(osd, vpp, hdr, dv, di), if close, will cause system crash >> S4_USB_COMB domain: for usb, if not always on, all usb status will clear to 0, that's not right status for usb Yes, I understand, this is teh same as for other SoCs (e.g. A1.) The solution is not to set the domain to always on. The solution is for the drivers for the devices in these domains use runtime PM so that when the drivers are active, the power domain does not get shut off. >> S4_ETH: for ethernet online wakeup, and if power down, status also not right OK, this one makes sense for "always on" since it used by firmware for wakeup. Kevin