From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752221AbdLGAzM (ORCPT ); Wed, 6 Dec 2017 19:55:12 -0500 Received: from mail-pg0-f43.google.com ([74.125.83.43]:43704 "EHLO mail-pg0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751990AbdLGAzK (ORCPT ); Wed, 6 Dec 2017 19:55:10 -0500 X-Google-Smtp-Source: AGs4zMYDr786sUfnL5VeB3jKCqYuJiYttrj+A10np+b11mltgACzB/gPTg0iKqLUVbUQM9o6QyIHxg== From: Kevin Hilman To: Arvind Yadav Cc: ulf.hansson@linaro.org, carlo@caione.org, ben-linux@fluff.org, adrian.hunter@intel.com, vireshk@kernel.org, maxime.ripard@free-electrons.com, wens@csie.org, linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org Subject: Re: [PATCH 1/6] mmc: meson-gx-mmc: Fix platform_get_irq's error checking Organization: BayLibre References: <1510950502-22565-1-git-send-email-arvind.yadav.cs@gmail.com> <1510950502-22565-2-git-send-email-arvind.yadav.cs@gmail.com> Date: Wed, 06 Dec 2017 16:55:08 -0800 In-Reply-To: <1510950502-22565-2-git-send-email-arvind.yadav.cs@gmail.com> (Arvind Yadav's message of "Sat, 18 Nov 2017 01:58:17 +0530") Message-ID: <7hfu8nmk5v.fsf@baylibre.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Arvind Yadav writes: > The platform_get_irq() function returns negative if an error occurs. > zero or positive number on success. platform_get_irq() error checking > for zero is not correct. > > Signed-off-by: Arvind Yadav Reviewed-by: Kevin Hilman