From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45DCCC433FE for ; Sat, 19 Feb 2022 00:34:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240405AbiBSAec (ORCPT ); Fri, 18 Feb 2022 19:34:32 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:56742 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236378AbiBSAeb (ORCPT ); Fri, 18 Feb 2022 19:34:31 -0500 Received: from mail-pl1-x636.google.com (mail-pl1-x636.google.com [IPv6:2607:f8b0:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 192CA177E6F for ; Fri, 18 Feb 2022 16:34:14 -0800 (PST) Received: by mail-pl1-x636.google.com with SMTP id u5so8403279ple.3 for ; Fri, 18 Feb 2022 16:34:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=N2mb/fnXiK+55Vayu1WQaDGcQm6fHIlg0WJV5p4N/HY=; b=vhpvpYAs72r/uoSL/BUaAusH6XKA4rAULu6qjHWYo27jOy1C6kM9j5tc1Az/Esg0n+ FIOoL1tgzkQ9bIQz2F3q90+Bps0EPIorHHEdHbZIVqHLPyPSB73rdhlXru65MTfByH59 Newd+wujsKTxWviQyz6zZe1F9pjl4rRdCaGC92BJL9pgI6PbUqQjZx/sgR1F83Px1HYs UUdtOicItV1IdSw8I9tgzri27OuyH8j/3J+hd8TKLNaRGWCfo+74ClOd90Qrmng3KlOd b2PRktm+Sm6qOC1/T9BNb9qvzmS8jeA4BSScIvYwNokGxI37wp3LhcFPjWjivHq3pn4V Sudw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=N2mb/fnXiK+55Vayu1WQaDGcQm6fHIlg0WJV5p4N/HY=; b=gvy6GD44DTbD4OelRSXKU4N+Ap/OPd/fFjx+tsrI88xAbwqJ2YNavJ2lmimvKw+i7N 98bfo8PJuC1mltPQb/d/X1sB2nTwaJePljMxtuwvtB3qcXZuwxaKLWCTYY0da79RA8b2 CwZK90s514TwRx2PJqrZ4x2nxA/aAG3eEoqcEzfQxEw+mSW8h8ivU9SuYQfm9HWOO+Z7 NXwJqeYgIQfqdaA7Dgj2E61HcOQLU4PZDU7fhZVq+yPTQXeK8xd6bpgpZzDmsfuG8ut4 e8OfTxD+ej3HlGgXs0CIFc+qkOAZS7yMnGi8edEQRHIGiDYQjdNeMopkqZk9MBRrvHak OcNg== X-Gm-Message-State: AOAM532IXSXGYqi4NQDv4uKT0+T5Tl0yxoiFxWKxxrC9Jiyjp7/0Bj96 LGXPdK8lSC2GgzAr6NLU4vdlzQ== X-Google-Smtp-Source: ABdhPJwVYQwlCngXM8fnMUumYkNGCOKPefj15RGXF11ZsFIDjKByrvfXXFy68PJeKQKdfkbdD+ttrA== X-Received: by 2002:a17:902:d683:b0:14c:c0a9:34f3 with SMTP id v3-20020a170902d68300b0014cc0a934f3mr9482203ply.109.1645230853581; Fri, 18 Feb 2022 16:34:13 -0800 (PST) Received: from localhost (c-71-197-186-152.hsd1.wa.comcast.net. [71.197.186.152]) by smtp.gmail.com with ESMTPSA id h16sm4149298pfh.40.2022.02.18.16.34.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Feb 2022 16:34:13 -0800 (PST) From: Kevin Hilman To: Rong Chen , Ulf Hansson , Neil Armstrong , Jerome Brunet , Martin Blumenstingl , 1131046452@qq.com, linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org Cc: 45581586@qq.com, Rong Chen Subject: Re: [PATCH v2] mmc: meson: Fix usage of meson_mmc_post_req() In-Reply-To: <20220216124239.4007667-1-rong.chen@amlogic.com> References: <20220216124239.4007667-1-rong.chen@amlogic.com> Date: Fri, 18 Feb 2022 16:34:12 -0800 Message-ID: <7hiltbitiz.fsf@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Rong Chen writes: > Currently meson_mmc_post_req() is called in meson_mmc_request() right > after meson_mmc_start_cmd(). This could lead to DMA unmapping before the request > is actually finished. > > To fix, don't call meson_mmc_post_req() until meson_mmc_request_done(). > > Signed-off-by: Rong Chen Reviewed-by: Kevin Hilman