From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752352AbdI3Ufg (ORCPT ); Sat, 30 Sep 2017 16:35:36 -0400 Received: from mail-wr0-f177.google.com ([209.85.128.177]:45334 "EHLO mail-wr0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751404AbdI3Ufb (ORCPT ); Sat, 30 Sep 2017 16:35:31 -0400 X-Google-Smtp-Source: AOwi7QCQT1qubKkI3EdwvZ9T+Q3i8xaJWxhJFwPVJBKNUyI1BePbUhKYJs3dXu4qK2gCAWwcNb+IkQ== From: Kevin Hilman To: Jerome Brunet Cc: Linus Walleij , Carlo Caione , linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Martin Blumenstingl Subject: Re: [PATCH 0/8] pinctrl: meson: clean pin offsets Organization: BayLibre References: <20170920133927.17390-1-jbrunet@baylibre.com> Date: Sat, 30 Sep 2017 22:33:59 +0200 Message-ID: <7hmv5cdiyw.fsf@baylibre.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Jerome Brunet writes: > The initial goal of this series was move to TEST_N pin from the EE > controller to AO controller, where it belongs. This meant modify the > EE_OFF value. > > This offset is a quirk we brought from the vendor driver when it was > initially merged. There no reason to keep this around and we could simply > let pinctrl figure the pin base value. > > Removing this offset, while simple, ends up being quite a patch bomb. > This is why I split the change over 5 first patches, so the important > change, patch #1 remains visible. Of course, to avoid breaking bisect, > these first 5 patches should be squashed into one. (If you prefer that I > squash it myself, I may have to send you a PR as the patch would exceed > VGER 100000 characters limit) > > The last change is this series, while not directly related, also requires > to adjust the gpio-line-names property in DT. Having these changes going > together would make it easier to coordinate the DTS changes. > > This was changeset has been test on gxbb P200, gxl libretech-cc. It was > also boot tested on meson8 (Thx Martin!) Really nice cleanup, thanks! Reviewed-by: Kevin Hilman Kevin