From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751711Ab2AQGNI (ORCPT ); Tue, 17 Jan 2012 01:13:08 -0500 Received: from b-pb-sasl-quonix.pobox.com ([208.72.237.35]:64041 "EHLO smtp.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750916Ab2AQGNG (ORCPT ); Tue, 17 Jan 2012 01:13:06 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; q=dns; s=sasl; b=UnTRmuNZGjIirqK0x6ykVLBJ3D9vHLY/ gMVTT0DBrr0BCrsAdiZSlxdCVQIjZVQ7wGxm2nrQZ4XL4qjx7bRXkC+Z+DWBqo7j DKUdRn6IHsKbiNcuRPHv4fFa/YPyBmFLA96g2sLf68IJtbfr0c7eSkyC0m5c4ZGb 47iBBdhum9Q= From: Junio C Hamano To: Pete Harlan Cc: Linus Torvalds , Mark Brown , Liam Girdwood , linux-kernel@vger.kernel.org, Git Mailing List Subject: Re: Re* Regulator updates for 3.3 References: <20120109073727.GF22134@opensource.wolfsonmicro.com> <20120110184530.GE7164@opensource.wolfsonmicro.com> <20120110222711.GK7164@opensource.wolfsonmicro.com> <7vmx9v7z1r.fsf@alter.siamese.dyndns.org> <7vehv77xeq.fsf@alter.siamese.dyndns.org> <7vzkdu7miv.fsf@alter.siamese.dyndns.org> <4F136BE4.4040502@pcharlan.com> <7v62gbussz.fsf@alter.siamese.dyndns.org> <4F15080C.6060004@pcharlan.com> Date: Mon, 16 Jan 2012 22:13:02 -0800 In-Reply-To: <4F15080C.6060004@pcharlan.com> (Pete Harlan's message of "Mon, 16 Jan 2012 21:33:00 -0800") Message-ID: <7vboq2uaa9.fsf@alter.siamese.dyndns.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Pobox-Relay-ID: 51068708-40D2-11E1-8E2A-9DB42E706CDE-77302942!b-pb-sasl-quonix.pobox.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Pete Harlan writes: > ... The > only time I think I'd prefer "LEGACY" is if you're planning on > deprecating and removing it eventually and you want to indicate > something to that effect in the name. The discussion that led to the naming of that LEGACY token needs to be re-read, then. The kind of "LEGACY" you prefer is exactly why the environment variable is called LEGACY in the patch you are commenting on, written in response to Linus's suggestion to switch the default, even though I am not 100% buying it. Having said that, I think I am wasting my time responding to this thread during the feature-freeze period for v1.7.9, as I am not a big fan of switching the default without adequate warning and transition plans, after getting burned by the "'git-foo' vs 'git foo'" flames back in the v1.6.0 release. We would likely to take a gradual and smoother migration route to transition, e.g. v1.7.9 to introduce "merge --edit", v1.7.10 to introduce a configuration variable merge.edit (lack of which gives a warning and an advice message while defaulting to 'no' to preserve the traditional behaviour), and finally v1.8.0 (or v2.0) to flip the default to 'yes' (while the configuration still giving a warning and an advice message) that "merge --no-edit" can still countermand. So you have until v1.7.10 to decide a good name for the overriding environment variable.