mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: Jeff King <peff@peff.net>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	linux-kernel@vger.kernel.org,
	Git Mailing List <git@vger.kernel.org>
Subject: Re: [GIT PULL] sound fixes for 3.6-rc6
Date: Thu, 13 Sep 2012 08:14:27 -0700	[thread overview]
Message-ID: <7vhar29cq4.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <s5hligeyrz8.wl%tiwai@suse.de> (Takashi Iwai's message of "Thu, 13 Sep 2012 15:25:47 +0200")

Takashi Iwai <tiwai@suse.de> writes:

>> I can't reproduce here. What is your exact request-pull invocation?

This question was not answerd.  Did you ask request-pull to ask for
a branch to be pulled, or did you ask it to ask for the tag to be
pulled?

If the former, I would have say it is a pebcak.  Linus asked you to
ask a signed tag to be pulled, and you want to have the tag to be
pulled, but if you do not give "git request-pull" the tag but a
branch that the tag points at, the command does not have a good
reason to countermand your (apparent) wish that the branch is what
is to be pulled.

>> Is request-pull showing a warning like:
>> 
>>   warn: You locally have sound-3.6 but it does not (yet)
>>   warn: appear to be at git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git
>>   warn: Do you want to push it there, perhaps?
>
> Hm, it looks like the check is performed only for tag objects.
> In the example below, no warning appears:
>     % git tag mytest for-next
>     % git request-pull mytest~ git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git mytest
>
> With an annotated or a signed tag, git seems giving a warning like
> above, indeed.  So my test seemed wrong.  Sorry for the noise.

OK.

  reply	other threads:[~2012-09-13 15:14 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-13 11:43 Takashi Iwai
2012-09-13 11:51 ` Linus Torvalds
2012-09-13 12:03   ` Takashi Iwai
2012-09-13 12:28     ` Takashi Iwai
2012-09-13 13:03       ` Jeff King
2012-09-13 13:25         ` Takashi Iwai
2012-09-13 15:14           ` Junio C Hamano [this message]
2012-09-13 15:26             ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vhar29cq4.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peff@peff.net \
    --cc=tiwai@suse.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®