From: Junio C Hamano <gitster@pobox.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>,
Liam Girdwood <lrg@ti.com>,
linux-kernel@vger.kernel.org,
Git Mailing List <git@vger.kernel.org>
Subject: Re: Regulator updates for 3.3
Date: Tue, 10 Jan 2012 18:28:32 -0800 [thread overview]
Message-ID: <7vmx9v7z1r.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <CA+55aFxvQF=Bm4ae6euB_UO8otMCuN9Lv37Zn3TpE-L7JH3Kzw@mail.gmail.com> (Linus Torvalds's message of "Tue, 10 Jan 2012 14:54:27 -0800")
Linus Torvalds <torvalds@linux-foundation.org> writes:
> Addid junio and git to the cc just to bring up this issue of bad UI
> once again. I realize it could break old scripts to start up an editor
> window, but still..
It is a non-starter to unconditionally start an editor. We would need a
good way for users to conveniently say "I am doing this unusual merge that
needs to be justified, and I want an editor to write my justification".
Obviously, "git merge -e regulator/for-linus" would work and is just three
keystrokes, which can be said "convenient enough" once the user gets used
to, but I think this is still inadequate as a solution, as the real
problem is it is _too_ easy to forget to give the option. Until the user
becomes _aware_ of the issues, it will not even occur to the user that
s/he _has_ to justify a merge (or not create a merge at all) in certain
circumstances and directions. After all, you have been repeating the "do
not make meaningless merges" for the past five years on the list. UI tweak
alone will not fix that.
If we are to rely on user's conscious action, I think it may be something
like a set of configurations that say things like:
- This branch is for advancing a specific topic, and not for merging
random development that happen elsewhere;
- This branch is for merging works by people downstream from me;
- This remote tracking branch (and by extension that branch at that
remote that uses this as its remote tracking branch) is my upstream and
I should not be merging back from it; and
- This remote tracking branch is my downstream, and I should freely merge
it when I heard it is ready.
and depending on the combination of what is being merged into what, toggle
the --edit option by default for "git merge" when neither "--edit" nor
"--no-edit" is given, just like "git merge" defaults to "--edit" when
merging an annotated tag.
next prev parent reply other threads:[~2012-01-11 2:28 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-09 7:37 Mark Brown
2012-01-10 18:27 ` Linus Torvalds
2012-01-10 18:45 ` Mark Brown
2012-01-10 19:18 ` Linus Torvalds
2012-01-10 22:27 ` Mark Brown
2012-01-10 22:54 ` Linus Torvalds
2012-01-10 23:17 ` Mark Brown
2012-01-11 2:28 ` Junio C Hamano [this message]
2012-01-11 2:47 ` Linus Torvalds
2012-01-11 3:03 ` Junio C Hamano
2012-01-11 3:14 ` Linus Torvalds
2012-01-11 6:59 ` Re* " Junio C Hamano
2012-01-11 16:23 ` Linus Torvalds
2012-01-16 0:14 ` Pete Harlan
2012-01-16 23:33 ` Junio C Hamano
2012-01-16 23:43 ` Martin Fick
2012-01-17 5:33 ` Pete Harlan
2012-01-17 6:13 ` Junio C Hamano
2012-01-11 3:21 ` Linus Torvalds
2012-01-11 18:40 ` Paul Gortmaker
2012-01-13 19:12 ` [PATCH] merge: Make merge strategy message follow the diffstat Junio C Hamano
2012-01-13 19:27 ` Nguyen Thai Ngoc Duy
2012-01-13 19:49 ` Linus Torvalds
2012-01-17 8:03 ` Miles Bader
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vmx9v7z1r.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=git@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®