From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 902F5353A73 for ; Sun, 26 Jul 2026 08:22:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785054161; cv=none; b=LOmVa7lHej/GG44IbXVlq1Je0br6YaXrZP6L3HxUyWvR2HS9pFXVxCn9DpUgpMWyiCHvDLIt3OIigCjhvNUL1uSxvbBH5W3McVGGRBVKDPsAEVJLYRFMN1g5j9vQar9R5r/t3mGkqRY/aHHoy9Z5MGIEB0c5ntulR+JU0mVhFU8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785054161; c=relaxed/simple; bh=4h4dnkwrZ3RZrxJ6YzDW7pZjUySnqqbJvWxtu0QhyO8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=jYM95u340WBDUwrTmx118mzfPEIzJTd2//YKD5lw99HUpaefNlBOQe6IB94rbXhv/eENm5Ml9oorJVNoiV5ZKMMDZ23YGK0nimrr6N3hp+Vq0NbSXJSJV8+Vx16bSPVA0tjk/7zUBIT2IwYGBvLZMWbQnOtfAzmQP3GOfm/mwwA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b=Xl3PUy3p; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b="Xl3PUy3p" Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 02DC42F; Sun, 26 Jul 2026 01:22:34 -0700 (PDT) Received: from [10.164.11.0] (unknown [10.164.11.0]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2C79A3F86F; Sun, 26 Jul 2026 01:22:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1785054158; bh=4h4dnkwrZ3RZrxJ6YzDW7pZjUySnqqbJvWxtu0QhyO8=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Xl3PUy3pyzy3Y+fWxTQkLqWNhQOxOAZD5iTokQiCpBR4W3PFE47C9oioz2kzWcoIR RXMoe5FsA8WuAuAZAU4bogJbqFPDzHBow/1ovtF5WNa3OpS4LKJttecDlVsTSe/9Gg ry4cro7aG8MbO00lmeusdLJ89MPTrMTStI4WgTWo= Message-ID: <8001e108-62a7-452a-93ef-8e21416a0cd1@arm.com> Date: Sun, 26 Jul 2026 13:52:31 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/5] mm/rmap: convert page -> folio for hwpoison checks To: Andrew Morton Cc: "Lorenzo Stoakes (ARM)" , david@kernel.org, muchun.song@linux.dev, osalvador@suse.de, riel@surriel.com, liam@infradead.org, vbabka@kernel.org, harry@kernel.org, jannh@google.com, lance.yang@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, ryan.roberts@arm.com, anshuman.khandual@arm.com References: <20260713050050.1017741-1-dev.jain@arm.com> <20260713050050.1017741-2-dev.jain@arm.com> <8d2f756a-12a2-43bb-8849-3e71c1ce5d8f@arm.com> <20260725190721.f2e121f118ef817e42bb3874@linux-foundation.org> Content-Language: en-US From: Dev Jain In-Reply-To: <20260725190721.f2e121f118ef817e42bb3874@linux-foundation.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 26/07/26 7:37 am, Andrew Morton wrote: > On Sat, 25 Jul 2026 13:06:25 +0530 Dev Jain wrote: > >>>> @@ -2204,7 +2205,11 @@ static bool try_to_unmap_one(struct folio *folio, struct vm_area_struct *vma, >>>> /* Update high watermark before we lower rss */ >>>> update_hiwater_rss(mm); >>>> >>>> - if (PageHWPoison(subpage) && (flags & TTU_HWPOISON)) { >>>> + /* >>>> + * With TTU_HWPOISON, we only expect small folios or hugetlb >>>> + * folios here for now. >>>> + */ >>>> + if (folio_test_hwpoison(folio) && (flags & TTU_HWPOISON)) { >>> >>> As per v2 discussion, I feel this could be tightened up, maybe something like: >>> >>> /* unmap_poisoned_folio() only refs order-0 or hugetlb folios */ >>> >> >> I can do this. But note that this series is in mm-unstable already - what should >> I base the v4 on? > > Ordinarily basing on latest Linus works. But this patchset has ~450 > patches ahead of it and a quick trial merge wasn't promising. > > I could drop the v3 series so you can base on next mm-new, please lmk. > > Or > > mm> git log --oneline | grep "mm/rmap: convert page -> folio for hwpoison checks" > bb2f8a7eb126 mm/rmap: convert page -> folio for hwpoison checks > mm> git checkout bb2f8a7eb126^ This one looks good, I'll do this. I'll wait for Lorenzo's (or any others) potential review comments for two days before I send this.