From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f65.google.com (mail-ed1-f65.google.com [209.85.208.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A6D2336BCC0 for ; Tue, 17 Feb 2026 16:41:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.65 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771346466; cv=none; b=TfgDKxSsFe4OWhQyyDaoEIp58rsWe6XJttbal48Nd4Q9c6AVLpgogn/nt59ceFyxsAa2RJfs66nM5hCEJVD7T/bu/7JwJ/DK2wB/rnntdK0Gc+YBvbhLLfYmqrQ/6yokixICPem+tq9qamlbOBkD65JJutvvXMAQJC402SYzLTI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771346466; c=relaxed/simple; bh=r/mWn0NTZppbdGJFnI/ErDwdANkgeIegPSZLoS1BE5U=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=FOaDAw5QuuaBlKpDXy7HSVxDcJEJSVP8CREVlWr6nFv46zz5TeHpOtzAq9L4cVyqIq5Ta1kLJyTRwzfMSLr2GgmynsxbTkp4rTCFsWCdw3/0qGbgM+qfbdeUjHObjFPdfnNpjlM1h78wsTSYVTQr4UQMWyukGHy4byRU5vcWnK8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=YUdwSYjP; arc=none smtp.client-ip=209.85.208.65 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YUdwSYjP" Received: by mail-ed1-f65.google.com with SMTP id 4fb4d7f45d1cf-65c1ed7b9aeso243789a12.0 for ; Tue, 17 Feb 2026 08:41:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771346463; x=1771951263; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding :disposition-notification-to:references:in-reply-to:date:cc:to:from :subject:message-id:from:to:cc:subject:date:message-id:reply-to; bh=r/mWn0NTZppbdGJFnI/ErDwdANkgeIegPSZLoS1BE5U=; b=YUdwSYjPxvt42sZO1yGY+b5csVVU2h8gcvYtPbVrfVHM+krzUNOLsG2QhjeOOVbshC hJXnt7jDKB3gPDlQAd0u6+ZLU7FPFInemnBZ+CWCD/gR9cU7dpm1gnIxnf1ReehJ4nmR sOgBgfsd3kjv1wy9r19BnXse4bWIC08Pok7kzaqRgeh2pjitev2Qai1i37Qn7+D/m2M+ i3W0E3sn0nt02hjTQpntXzOzlH6KtmK/vMDj7jzZ8/TjWaoeoTE6ZlWIoNfWTJ49cC36 FqiJOu/U2i3xtQtklyKf0bsPCz8zpyvllazv/tMK1hmze5GQ9w3sBhmHw2Eyf5IHf1Qi Rnxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771346463; x=1771951263; h=mime-version:user-agent:content-transfer-encoding :disposition-notification-to:references:in-reply-to:date:cc:to:from :subject:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=r/mWn0NTZppbdGJFnI/ErDwdANkgeIegPSZLoS1BE5U=; b=dY1A132ZMCzzbkA/R3xnutfqfrAtxTLOJ7i+3GDFyELFnjtZ6GlVGur4Jnh7Rh9eOx O5HEI0/uSTdj6D674drjkaEXbaTI+CeI+r1fLLJt+QMBOsk0fUqHxrB0PiyzJ+hGOF7T EfJtEfrGB457V9llRXKf9ai9K4EkRwEbr7y+pJrfW0zigkKwn7aeWMcCf7NMwcESdQI5 XhyW4GHCvC6tP1j/sQHNTCPP6nNGiHtMPDvUG+6iqLGMPlFg4RjIu5G1XBpczkg9wLeV v4HEG/9yq3YRTP36RMI4P3yScJUD/8qLaxI0/mKv54GPTRo52XYLyqosQirIrlW6rd3r /i/Q== X-Forwarded-Encrypted: i=1; AJvYcCVlni2ctSPvNmDIL9n70KXIzZz0FAihILk9EfM7MZ77dLOCChYlISCr/7WYb6JhCv+konPy1F25nBBDUmc=@vger.kernel.org X-Gm-Message-State: AOJu0YzJiRh6+Shz7yaVURT/yXT0PcR3agmFyrZZp3/U+XNLAxkOi72u LUj8M7sTEm+F35ECetTK3F5u/+crWL/72dxk8DxWUu/FGH6SQBa3YAN6 X-Gm-Gg: AZuq6aINlyHDAQBo0HUBCEzLs1Fzo0URTA9rH7jafgWC+eyWUe7wcIrrTaAw77IU4hz o/S4gKWVlifPao60HQkktGrio4exui4kfAqL3ocJbReZ3jdf326jZ8TSIAcoUP9/Mwe009fNPb3 EdqWxkXHpP6i7pdKeLP8L8jS1GoHJSPSwjKe+6zWw0KH3WNfF6PfmgfmT/1quvvHm1KGCkwuzIa T+lNjYl/MwfFITwk5qSApWSWY2De/xIrxg96vUwgORQ22UnSehEQ575GlpLQH9psquCVagiOh25 ZibopNFD4oBT7LRDmQfaJb+HtLszXhg1MUUoqfC7VzGxXrMtoTtd9HU7JfJTQ0OXUsGXhf6F6zs NWDASEpOGX73Sxo/NvcAr8y6utwuKfVpZaBsQgKn5ghjKkH+Hokdr/MhmNMl7y2v7zKFuISBoOg GLN5SemQ0NGS93rPur2wKbM7P7dMmOAxXUoac37earI7M7Oj9pC/BlBTWLug4AQpjs8+hPxTq/4 wuB08xYTXc= X-Received: by 2002:a05:6402:5244:b0:65b:a76d:6ff6 with SMTP id 4fb4d7f45d1cf-65bad140f57mr4283834a12.3.1771346462611; Tue, 17 Feb 2026 08:41:02 -0800 (PST) Received: from [192.168.1.239] (87-205-5-123.static.ip.netia.com.pl. [87.205.5.123]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-65bad3f1294sm2511183a12.26.2026.02.17.08.41.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Feb 2026 08:41:02 -0800 (PST) Message-ID: <8006baea7c35850de3a39f155b7aa004c4896495.camel@gmail.com> Subject: Re: [PATCH v4 23/27] drm: Add passive_vrr_disabled property to crtc From: Tomasz =?UTF-8?Q?Paku=C5=82a?= To: Michel =?ISO-8859-1?Q?D=E4nzer?= , alexander.deucher@amd.com, harry.wentland@amd.com, sunpeng.li@amd.com Cc: maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, siqueira@igalia.com, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, bernhard.berger@gmail.com, daniel@fooishbar.org Date: Tue, 17 Feb 2026 17:41:00 +0100 In-Reply-To: References: <20260216164516.36803-1-tomasz.pakula.oficjalny@gmail.com> <20260216164516.36803-24-tomasz.pakula.oficjalny@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.3 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Tue, 2026-02-17 at 09:21 +0100, Michel D=C3=A4nzer wrote: > On 2/16/26 17:45, Tomasz Paku=C5=82a wrote: > > Many TVs and other HDMI sinks suffer from blanking and possibly other > > glitches when VRR is toggled. With VRR present on such sinks and > > vrr_on_desktop enabled, they behave like the signal is always variable, > > even in fixed refresh rate situations. DisplayPort and eDP enforce > > seamless VRR transitions but HDMI unfortunately doesn't. > >=20 > > Keep VRR toggled if it's supported and not explicitly disabled. It can > > be used for any VRR sinks, but this is mainly targeted for HDMI. > >=20 > > Functionally, for an end user, this is the same as normal, fixed refres= h > > rate mode. The only difference is that sink is kept in VRR state which > > enables seamless transitions into/out of variable refresh rate. > >=20 > > Basically, the driver shouldn't change it's behavior around VRR_ENABLED > > set to false, jut keep sending info packets/frames with VRR/FreeSync/ > > G-Sync/HDMI VRR active. > >=20 > > Enabled by default for sinks that claim it's support >=20 > Having a negation term like "disabled" in the property name can be confus= ing (as it involves double negation when the property value is 0) and is be= tter avoided. >=20 I understand that and felt a little cheaty by doing this but I couldn't for the life of my figure out how to make it so a driver could override this by default, before the compositor will set this. Would a "set" function work, just like for "capable" properties? =20 I 100% believe this "Passive VRR" for HDMI should be the default and helps massively but I'm not even that convinced if this must be user configurable. Alex asked to make it a property, but In the end, it's not something thsdat can be controlled on other OSes. I still believe that users should be able to change this somehow, but if amdgpu module setting wasn't a good fit, I don't know what is. In the end, I can just yeet all this completely and hardcode freesync_on_desktop =3D true for HDMI like it's done in the windows driver.