From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5C5101DD9AC for ; Sat, 28 Jun 2025 14:33:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751121227; cv=none; b=f65QReNCbAE+FHvsdmEOthIQds6FRCL4yqiW0kW0+ukH7Rl9KGFuahkl/7fJTzIQMmUDz0zhJVpOPdK6k1nxw1qsPqiXNdmC+SFCO46bIarSQgZDtbFWnRHYSo0Jyi2zhjsnnq/sb3S58ilaAC5fnYgsn1CnuT1Ht2lXnYGLtTQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751121227; c=relaxed/simple; bh=H/z1iLiEZXOU4uzftN0AnKLKkX0XaCAs2CMguHD8mao=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=fbfo8684wECIeuqhv+vxeU75zoTV7o+SgGES3uMTlyPzJz6vwt6DWeISYg9Qn7WL5F61Dcn88M4qR/YZnMuKMlJ4ma4HvbFo61QeDpi9g0CiN/5sn1IYejjldwv7+aN5R4fLKTZF1P6QDpeahblk4noBf3k08BT2QjY45ztvExc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Er8+EO/Z; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Er8+EO/Z" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 55SEJOdh022880 for ; Sat, 28 Jun 2025 14:33:45 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= HuVOl6ZxJLGQ7rcb1ieCWzhWudrjJUbl0x5e2lJC0QE=; b=Er8+EO/ZK69WgHqO Ck2djVAHNvo8e6tzV4dwm764jGaPgLwdDVIGgy8/qCY7wUkD+4dC7Sty8lMi+zcZ DzmQRqn7/ydTmUyL6k/+mh3pRFoE/whwMnSDnlOCW6VeUkNKo/81nYvb3nxkc2Wl DbF8C+KXaa9zFOROIXMJn0goehAcweStzWOSg5DNTD8J+64fd/to8A1zwwn/imai ObPbhdlPOZLsfOBknjSP+d8Zcea8/3zuJpsqmFn4Gf+88nNSTg1Aqhp62yydrgu0 5Jry/U602mxmMnLyy2tj54NBra1k0DbZdlojYgVmAwjtqczNXjVnQpAVbxrUkF6u AohWjQ== Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 47j7d9rtvx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Sat, 28 Jun 2025 14:33:45 +0000 (GMT) Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-6fae04a3769so4971756d6.1 for ; Sat, 28 Jun 2025 07:33:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751121224; x=1751726024; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=HuVOl6ZxJLGQ7rcb1ieCWzhWudrjJUbl0x5e2lJC0QE=; b=PujrRyOH0xMI/tGIqUdjUYANPYXwBwxn5fN2cL0AULyBi6QcO/yCvBn0OVSSXKiisR ouhyVtlmR8YJZ1perFWrx6Fv+SPUIIrlrUkX0WN8jbMVudts7k3Gn6HkB3A+3oglRES0 6FHHl2D6pjaJI2tIuqacvqeASXxD5Dl3JdXJeQaIKPgFxJENK39yYiqbDmGe1s4xBiGp asr9fnrdiu22f81tPG9UWzYPXOScLKjGpmYtrmJgktznpT8s/3VKW6qV2/jqL6jWsy0Z 1kh/iyCkywBMFW3wbJM+Dyv7ufHeRXg9BxgP8EWfoRo1tNeCIffay44irabd82OIWXCC X67Q== X-Forwarded-Encrypted: i=1; AJvYcCVETUOVO3Lj3Zfbwbe8wFOTJWSoVjm1cJV4kQqX92CSLFhHoXaDMQB58EgxvgNHH3zkO8TzrMGZgpXJNHI=@vger.kernel.org X-Gm-Message-State: AOJu0YzE8/cJU7HmffEqW4uUpLhOQEK3+rxKOilBT+WfVoD8Xt+mal3E yiNtJ1hnMbrJAEjiFNJVvmUCsCs+wF5s1XTQ/07RI6LMMmEMcEk6YOxYBk5mae2Ajp6rDdBa/2k osDcqJvwQZmDuM2oMf7JwBYcTB2bhZ0yynN46SEIV4M8bFk+PmpO0VF3WX2ETMdiq4hQ= X-Gm-Gg: ASbGnctImmxFcgN3/3n3HAsLXiw2GD2uU5JKOMnPDbM78+RbX0WYUfAGit0ifkgInkI VHZVN/fM0zZolndFslvw/fwTPHdj4+mm+ZQw5F8YARjMMZypYNnkB7hCAOrRIBpIom6kYzKJSyJ qCbtB/ENc+SIQIBC3FpGPXPSOEZ4mBLqchKtfxiAsWt+jqWpKijCE4wS527VKePT5ZY6a3/tOFe 9P/KBCiP9pPSPiI9+RENQSVH5umJI//AErLgcZHywHU2Uz5IDoGsbdBVp9jv4neSqfHLZpsvIHX t23ly64Qwx1tw/Vyz2FYmrccKeAC3tJ4n9PWUVzDwV/Si+HiS+D/D2BeeUkA12tXDrfRAHDM8Pr ghCI= X-Received: by 2002:a05:620a:468f:b0:7c3:d798:e8ae with SMTP id af79cd13be357-7d44c1e865bmr174082185a.2.1751121224203; Sat, 28 Jun 2025 07:33:44 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFqoPiCw9YRPSLc7lTHGilnDJ3WRFqDc+rvgBEJtqW7+0Cd1vSfc7+jJ37iPWQdoj4t8l0x/Q== X-Received: by 2002:a05:620a:468f:b0:7c3:d798:e8ae with SMTP id af79cd13be357-7d44c1e865bmr174080385a.2.1751121223668; Sat, 28 Jun 2025 07:33:43 -0700 (PDT) Received: from [192.168.143.225] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-60c831ff8b3sm3057699a12.67.2025.06.28.07.33.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 28 Jun 2025 07:33:43 -0700 (PDT) Message-ID: <80079934-c341-4557-b1fc-29e2c132dd3b@oss.qualcomm.com> Date: Sat, 28 Jun 2025 16:33:40 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] dt-bindings: pinctrl: document the SM7635 Top Level Mode Multiplexer To: Rob Herring , Luca Weiss Cc: Bjorn Andersson , Linus Walleij , Krzysztof Kozlowski , Conor Dooley , ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250625-sm7635-pinctrl-v1-0-ebfa9e886594@fairphone.com> <20250625-sm7635-pinctrl-v1-1-ebfa9e886594@fairphone.com> <20250627204432.GA45217-robh@kernel.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20250627204432.GA45217-robh@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNjI4MDEyMSBTYWx0ZWRfX9OrNDkuhRDuo QH4GmuDatMFTNRqTa8YbvtQiMeCkPdaczJq1GMq+kumF2ukaPS65Sv0QDuqaGfBFJO5anauoYCO gymGGtKHclYD45bq+wqSFQKotrFHYanbQAkYkLlc7eNh74WqDFzdD3ks2nhbK1NS95TRROzbGem Xz7dWPCW2pgt8/YMYssi0MRSjh7VhKW2WMwlp/tQ8t59cp0huCOs15xNy1Vn2PeFO+10k+fRKMR hIWKDnt3SM4GsQSf/Wk6nyWBt5z674MN8+/Y0HcwEhoEbukmfSMUshgNptOd9IMmjnycP0Tl5ad iAlV9DA0TFGE4IwCRfMCxxft61Z1QyuoV0vzpTG+kOfPBoscvmh4v9/VCKATClMgeW5BfEfD83y LvWyWbgeyUDbHRZja+88KeCLyKesPA1HdVWAm5MRS4q7xJkGtx+jeUQ9gTJbbgmq1NRgKGBQ X-Proofpoint-GUID: Doh8CLQ7C-gkalN6q5iusLGm8UgPA8FS X-Authority-Analysis: v=2.4 cv=RrbFLDmK c=1 sm=1 tr=0 ts=685ffd49 cx=c_pps a=wEM5vcRIz55oU/E2lInRtA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=6IFa9wvqVegA:10 a=gEfo2CItAAAA:8 a=6H0WHjuAAAAA:8 a=z9lO1hKNhkvoeKZr6R8A:9 a=QEXdDO2ut3YA:10 a=OIgjcC2v60KrkQgK7BGD:22 a=sptkURWiP4Gy88Gu7hUp:22 a=Soq9LBFxuPC4vsCAQt-j:22 X-Proofpoint-ORIG-GUID: Doh8CLQ7C-gkalN6q5iusLGm8UgPA8FS X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-06-27_05,2025-06-27_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 mlxlogscore=999 adultscore=0 clxscore=1015 suspectscore=0 phishscore=0 bulkscore=0 malwarescore=0 spamscore=0 mlxscore=0 priorityscore=1501 lowpriorityscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2506280121 On 6/27/25 10:44 PM, Rob Herring wrote: > On Wed, Jun 25, 2025 at 11:12:01AM +0200, Luca Weiss wrote: >> Document the Top Level Mode Multiplexer on the SM7635 Platform. >> >> Signed-off-by: Luca Weiss >> --- >> .../bindings/pinctrl/qcom,sm7635-tlmm.yaml | 133 +++++++++++++++++++++ >> 1 file changed, 133 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm7635-tlmm.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm7635-tlmm.yaml >> new file mode 100644 >> index 0000000000000000000000000000000000000000..3f49239efb6e866015b40e3477a8bd0edd21b1fc >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm7635-tlmm.yaml >> @@ -0,0 +1,133 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/pinctrl/qcom,sm7635-tlmm.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Qualcomm Technologies, Inc. SM7635 TLMM block >> + >> +maintainers: >> + - Luca Weiss >> + >> +description: >> + Top Level Mode Multiplexer pin controller in Qualcomm SM7635 SoC. >> + >> +allOf: >> + - $ref: /schemas/pinctrl/qcom,tlmm-common.yaml# >> + >> +properties: >> + compatible: >> + const: qcom,sm7635-tlmm >> + >> + reg: >> + maxItems: 1 >> + >> + interrupts: >> + maxItems: 1 >> + >> + gpio-reserved-ranges: >> + minItems: 1 >> + maxItems: 84 >> + >> + gpio-line-names: >> + maxItems: 167 >> + >> +patternProperties: >> + "-state$": >> + oneOf: >> + - $ref: "#/$defs/qcom-sm7635-tlmm-state" >> + - patternProperties: >> + "-pins$": >> + $ref: "#/$defs/qcom-sm7635-tlmm-state" >> + additionalProperties: false > > Is there really value in continuing this complicated QCom pattern? Can > we just have 1 level or 2 levels only? The 1-level pattern is useful for states that contain settings for a single pin (or a common set of settings for multiple pins), whereas the 2-level one makes sense for groups of differently-set pins that are logically coupled (e.g. a set of SDHCI-active states) Only keeping 1 would increase the boilerplate as each group of logically-adjacent pins would need to be referred to individually in pinctrl-n = <>, whereas keeping only option 2 would increase boilerplate in the state definitions (think creating a 2d array for a single scalar value) So I think both are rather useful in their own regard.. Konrad