From: Stefan Wahren <stefan.wahren@i2se.com>
To: Nicholas Mc Guire <hofrat@osadl.org>, Eric Anholt <eric@anholt.net>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Dominic Braun <inf.braun@fau.de>,
Tobias Buettner <tobias.buettner@fau.de>,
Nicolas Saenz Julienne <nsaenzjulienne@suse.de>,
Luis Chamberlain <mcgrof@kernel.org>,
Phil Elwell <phil@raspberrypi.org>,
linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2] staging: vc04_services: handle kzalloc failure
Date: Fri, 19 Apr 2019 13:34:01 +0200 [thread overview]
Message-ID: <80087aaa-eea6-6258-341e-17814a210894@i2se.com> (raw)
In-Reply-To: <1555630268-17017-1-git-send-email-hofrat@osadl.org>
Am 19.04.19 um 01:31 schrieb Nicholas Mc Guire:
> The kzalloc here was being used without checking the return - if the
> kzalloc fails return VCHIQ_ERROR. The call-site of
> vchiq_platform_init_state() vchiq_init_state() was not responding
> to an allocation failure so checks for != VCHIQ_SUCCESS
> and pass VCHIQ_ERROR up to vchiq_platform_init() which then
> will fail with -EINVAL.
>
> Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
> Reported-by: kbuild test robot <lkp@intel.com>
> ---
Acked-By: Stefan Wahren <stefan.wahren@i2se.com>
prev parent reply other threads:[~2019-04-19 21:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-18 23:31 Nicholas Mc Guire
2019-04-19 11:34 ` Stefan Wahren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=80087aaa-eea6-6258-341e-17814a210894@i2se.com \
--to=stefan.wahren@i2se.com \
--cc=devel@driverdev.osuosl.org \
--cc=eric@anholt.net \
--cc=gregkh@linuxfoundation.org \
--cc=hofrat@osadl.org \
--cc=inf.braun@fau.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=mcgrof@kernel.org \
--cc=nsaenzjulienne@suse.de \
--cc=phil@raspberrypi.org \
--cc=tobias.buettner@fau.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®