mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dave Hansen <dave.hansen@intel.com>
To: Yongting Lin <linyongting@bytedance.com>,
	tglx@kernel.org, mingo@redhat.com, bp@alien8.de,
	dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com,
	seanjc@google.com, pawan.kumar.gupta@linux.intel.com,
	xin@zytor.com, babu.moger@amd.com, riel@surriel.com
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/cpu: Add INVLPGB CPU feature flag to /proc/cpuinfo
Date: Wed, 18 Mar 2026 10:58:26 -0700	[thread overview]
Message-ID: <8012d986-0d1f-47a2-8892-2b2dcc1339db@intel.com> (raw)
In-Reply-To: <20260318175204.21762-1-linyongting@bytedance.com>

On 3/18/26 10:52, Yongting Lin wrote:
> commit 767ae437a32d ("x86/mm: Add INVLPGB feature and Kconfig entry")
> introduced support for the INVLPGB instruction as a fast TLB
> invalidation mechanism. However, no corresponding CPU feature flag is
> exposed via /proc/cpuinfo.

The patch is probably OK, but the changelog is insufficient. Could you
please read through:

	Documentation/arch/x86/cpuinfo.rst

and use that structure to construct a justification for why this feature
is needed?

I'd also just appreciate a blurb on why you care. Why did you bother to
send this patch?

  reply	other threads:[~2026-03-18 17:58 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-18 17:52 Yongting Lin
2026-03-18 17:58 ` Dave Hansen [this message]
2026-03-18 18:23   ` Yongting Lin
2026-03-18 18:33     ` Dave Hansen
2026-03-18 18:34     ` Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8012d986-0d1f-47a2-8892-2b2dcc1339db@intel.com \
    --to=dave.hansen@intel.com \
    --cc=babu.moger@amd.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linyongting@bytedance.com \
    --cc=mingo@redhat.com \
    --cc=pawan.kumar.gupta@linux.intel.com \
    --cc=riel@surriel.com \
    --cc=seanjc@google.com \
    --cc=tglx@kernel.org \
    --cc=x86@kernel.org \
    --cc=xin@zytor.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®