From: POTIN LAI <potin.lai@quantatw.com>
To: Rob Herring <robh+dt@kernel.org>
Cc: Joel Stanley <joel@jms.id.au>, Andrew Jeffery <andrew@aj.id.au>,
Patrick Williams <patrick@stwcx.xyz>,
Allen Wang <Allen_Wang@quantatw.com>,
devicetree@vger.kernel.org,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-aspeed <linux-aspeed@lists.ozlabs.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 1/1] arch: arm: dts: update bletchley dts
Date: Thu, 10 Feb 2022 00:46:27 +0800 [thread overview]
Message-ID: <8016293e-5100-1cda-89ea-8a9b5491132a@quantatw.com> (raw)
In-Reply-To: <CAL_JsqLM552FjvjdECq56kYsx9+mPuyvpUNibtuH--pgyF4pDQ@mail.gmail.com>
Rob Herring 於 9/02/2022 11:33 pm 寫道:
> On Wed, Feb 9, 2022 at 4:04 AM Potin Lai <potin.lai@quantatw.com> wrote:
>> updates:
>> * seperate leds into multiple groups
>> * switch sled numbering to 1-based
>> * disable inchip rtc
>> * add flash1 in fmc
>> * switch spi2 pnor using spi-gpio
>> * update gpio-line-names
>> * add interrupt pin for each sledx_ioexp
>> * enable mdio3
>> * update ADM1278 shunt resistor (300 micro Ohm)
>> * add INA230 for each sled
> Please read documentation on writing commit messages. Answer why you
> are making the change, not what you are changing.
>
> Each bullet should probably be a separate commit. The question to
> answer is are there compatibility issues (what happens with old DT and
> new kernel and vice-versa)?
>
> Rob
Thank you very much for advising, will update this patch in new patch series.
Potin
prev parent reply other threads:[~2022-02-09 16:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-09 10:04 Potin Lai
2022-02-09 15:33 ` Rob Herring
2022-02-09 16:46 ` POTIN LAI [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8016293e-5100-1cda-89ea-8a9b5491132a@quantatw.com \
--to=potin.lai@quantatw.com \
--cc=Allen_Wang@quantatw.com \
--cc=andrew@aj.id.au \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patrick@stwcx.xyz \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®