mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tom Rix <trix@redhat.com>
To: Colin Ian King <colin.i.king@gmail.com>,
	Thomas Gleixner <tglx@linutronix.de>
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
	llvm@lists.linux.dev
Subject: Re: [PATCH] kernel/irq/matrix.c: remove redundant assignment to variable 'end'
Date: Fri, 22 Apr 2022 04:36:34 -0700	[thread overview]
Message-ID: <8016b196-6a39-8808-b1ff-286aacb2c8ca@redhat.com> (raw)
In-Reply-To: <20220422110418.1264778-1-colin.i.king@gmail.com>


On 4/22/22 4:04 AM, Colin Ian King wrote:
> Variable end is being initialized with a value that is never read, it
> is being re-assigned later with the same value. The initialization is
> redundant and can be removed.
>
> Cleans up clang scan build warning:
> kernel/irq/matrix.c:289:25: warning: Value stored to 'end' during its
> initialization is never read [deadcode.DeadStores]
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> ---
>   kernel/irq/matrix.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/irq/matrix.c b/kernel/irq/matrix.c
> index bbfb26489aa1..1698e77645ac 100644
> --- a/kernel/irq/matrix.c
> +++ b/kernel/irq/matrix.c
> @@ -286,7 +286,7 @@ void irq_matrix_remove_managed(struct irq_matrix *m, const struct cpumask *msk)
>   int irq_matrix_alloc_managed(struct irq_matrix *m, const struct cpumask *msk,
>   			     unsigned int *mapped_cpu)
>   {
> -	unsigned int bit, cpu, end = m->alloc_end;
> +	unsigned int bit, cpu, end;
Reviewed-by: Tom Rix <trix@redhat.com>
>   	struct cpumap *cm;
>   
>   	if (cpumask_empty(msk))


  reply	other threads:[~2022-04-22 11:36 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-22 11:04 Colin Ian King
2022-04-22 11:36 ` Tom Rix [this message]
2022-04-25 13:02 ` Thomas Gleixner
2022-04-25 13:06   ` Colin King (gmail)
2022-04-25 13:10 ` [tip: irq/core] genirq/matrix: Remove " tip-bot2 for Colin Ian King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8016b196-6a39-8808-b1ff-286aacb2c8ca@redhat.com \
    --to=trix@redhat.com \
    --cc=colin.i.king@gmail.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=llvm@lists.linux.dev \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®