mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Yan, Zheng" <zyan@redhat.com>
To: Minfei Huang <mnfhuang@gmail.com>
Cc: sage@redhat.com, idryomov@gmail.com, ceph-devel@vger.kernel.org,
	linux-kernel@vger.kernel.org, mhuang@redhat.com
Subject: Re: [PATCH] ceph: Avoid to propagate the invalid page point
Date: Mon, 21 Dec 2015 12:12:52 +0800	[thread overview]
Message-ID: <801FE0B8-0193-429D-8BB0-E505DDF22E36@redhat.com> (raw)
In-Reply-To: <1450493699-20983-1-git-send-email-mnfhuang@gmail.com>


> On Dec 19, 2015, at 10:54, Minfei Huang <mnfhuang@gmail.com> wrote:
> 
> The variant pagep will still get the invalid page point, although ceph
> fails in function ceph_update_writeable_page.
> 
> To fix this issue, Assigne the page to pagep until there is no failure
> in function ceph_update_writeable_page.
> 
> Signed-off-by: Minfei Huang <mnfhuang@gmail.com>
> ---
> fs/ceph/addr.c | 1 -
> 1 file changed, 1 deletion(-)
> 
> diff --git a/fs/ceph/addr.c b/fs/ceph/addr.c
> index b7d218a..6491079 100644
> --- a/fs/ceph/addr.c
> +++ b/fs/ceph/addr.c
> @@ -1149,7 +1149,6 @@ static int ceph_write_begin(struct file *file, struct address_space *mapping,
> 		page = grab_cache_page_write_begin(mapping, index, 0);
> 		if (!page)
> 			return -ENOMEM;
> -		*pagep = page;
> 
> 		dout("write_begin file %p inode %p page %p %d~%d\n", file,
> 		     inode, page, (int)pos, (int)len);

applied, thanks

Yan, Zheng

> -- 
> 2.6.3
> 


      reply	other threads:[~2015-12-21  4:13 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-19  2:54 Minfei Huang
2015-12-21  4:12 ` Yan, Zheng [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=801FE0B8-0193-429D-8BB0-E505DDF22E36@redhat.com \
    --to=zyan@redhat.com \
    --cc=ceph-devel@vger.kernel.org \
    --cc=idryomov@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mhuang@redhat.com \
    --cc=mnfhuang@gmail.com \
    --cc=sage@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®