From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f179.google.com (mail-oi1-f179.google.com [209.85.167.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 031CB21CC71 for ; Sun, 12 Apr 2026 18:45:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776019546; cv=none; b=Imahjtv5DdsTLPjWSiJXA8fy6QCQx/XUogtBlX8+wLjoY0MQx4oDSjxPnFbtCwLcRb/Au29oXpUTFJe0+C+viLFsb/ZzOAA2gdjWmMZ65t09byN1Jioy3UD9f+fReGNtWcOR/QsKt+0jrcIyGkkL8vM1fAGYNKJQwgpvRlR94yk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776019546; c=relaxed/simple; bh=oQzRgQ7NQPcP1cTNgd4z06Z6ADUV1qjY2dP5A5oq9kY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=KiL8tqwjf6OjtMAVWp5tfZJpuxOgXlOCQ6i2BY+i+b8S4tMxkbP/+yXPMqJOgpS3WgnhhafhY2CgdDZP6+BUnno18FkZfC2EhPY0DTP7t44unvMbkSFMD11yDfpDK9sXsfVDtFSPIvLGntag9cmOA1+ODE9gfv1o2+7tOKoYQ30= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20251104.gappssmtp.com header.i=@baylibre-com.20251104.gappssmtp.com header.b=OGW9U3WJ; arc=none smtp.client-ip=209.85.167.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20251104.gappssmtp.com header.i=@baylibre-com.20251104.gappssmtp.com header.b="OGW9U3WJ" Received: by mail-oi1-f179.google.com with SMTP id 5614622812f47-46f0fa0e398so2142883b6e.1 for ; Sun, 12 Apr 2026 11:45:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20251104.gappssmtp.com; s=20251104; t=1776019542; x=1776624342; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=M+ZO6rZv9NGV1Yj2nIfY3XI669Ebfty85k3Q8tYt5QY=; b=OGW9U3WJZDl6ektiEuFCczMHCtc+ME8EUqGijmbXrA0QcFfW72Wpq1CLFm6iX7Is81 tSj5PvDkSca2dGxoAYLyzNlePB/wldPvADeBtfSYw6PA2Xt/lqvF3kg52RZmALMLxCWs D9znPT2DUorWB2GT7c5s5YBOoNaivA6zAJmG57f7295gYFMlSW2Mb4j1MgOGYpm6qu2p 8O0zkfXdhX40Do9NSgf4bBItWgswnh5B129ftmAHDssNNc1yZGNNsiFhvTLIRK3utzIG IZRTWt0gRFF850mfyHPVMyCqpCBY8lk9xT9H/RRfTLkzS6z/cFvWD8W5QRiaGVVPGIsF iFFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776019542; x=1776624342; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=M+ZO6rZv9NGV1Yj2nIfY3XI669Ebfty85k3Q8tYt5QY=; b=sd3vR+ChZyFsIJt5G5AwGqmyJRai2+k0bRU1I4Nurq9cWidzCSRr8OdO5YpYF8S7s5 tXohigmXMHglTiGJZU92aTDgh7SIHyc436rblczlS0IKMb5GzIFh0QbyodxyY5f3/LHh qFeVR71tIHdvQ4n7AAXJf+mT6u36CZRKXRFrifI/H6iyUjQ9qnSrkPyiF7ao/O2q3ddB m92rYxfu+MAaucljDkneRFRxIhFhOwR6GOQPP9OXBLm214rpL0seId3aDLQHZUDeeMm1 vV7YAdQ12nVcF+TjvCea+NjMedQGD/9u+ehXZ3xT0wdWQd5FuAWBqxXPMX73mL9Ij4Sb qt3Q== X-Forwarded-Encrypted: i=1; AJvYcCVAVf6TCQnyp2TNIUKmTL7VY0+3WyVYbSI4dXNK+3ioF02gcEGjAqWc45iuQWoQDsEOWMxaFw9OkQZQ1TI=@vger.kernel.org X-Gm-Message-State: AOJu0Yw32tUQ7bH0HYzxvmJbr+OmZkrvpLcSonFO7bT8T3ThejV0gYbb kKqxfNFL1yRL3wPVtFgiuoAIRVteqpUtHppg4efk8H3JvSEJilvR2vbYngP4w+UIJL8= X-Gm-Gg: AeBDiesRuUnrfrZxtpZ+HVXxllfVNvYQJheXcZTszVIsPJp12Qpa1DKgrfZEX2qjZ7a /aCeRGVZCcXreo06qrvwlAe8RRLkyGEgmq6y4A+FYPboWqZ//RAyBWuqpMaVqMI36zL21OYzt25 q56DaNv02fwN4omupECHfP4qy2f87NhOD1R+RuVoxDRUAYqfQiKu4DM1qi4gbirScKKeIke+FCw tRkAVdpsv2HJGHgA5wZ3JG8A2ioas7BTdJNBvBDCMRNSxRjkeAVTC3xw7RaYtlqdvwy2hwlbqAP MIPF3TFUrhqOpXC6sNztQsfEIWd21JmXDd7hQ+8cj0qasXJA4S0MtcPtcHyF1XijjgUMt3GAWq3 b89kj2Fv8Rj0vs46OIlrD2BIDOa0Ph8qyLZtSDdy+pzEJmPFDlKwoiXSIGSjt4R/8D2H6vubNZo oXLtzL/cVmSicmi529ivNWVZ1gupbJDcTGitCod+p1wFp0BaTFha91fIdsfAmnHKqvxyHf7hjUb g== X-Received: by 2002:a05:6808:4f49:b0:45e:b623:f9b3 with SMTP id 5614622812f47-4789f7074ddmr5377663b6e.42.1776019541977; Sun, 12 Apr 2026 11:45:41 -0700 (PDT) Received: from ?IPV6:2600:8803:e7e4:500:5c13:5a8e:1b91:8035? ([2600:8803:e7e4:500:5c13:5a8e:1b91:8035]) by smtp.gmail.com with ESMTPSA id 5614622812f47-478a3666dbfsm4831509b6e.15.2026.04.12.11.45.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 12 Apr 2026 11:45:40 -0700 (PDT) Message-ID: <801badd3-d10d-4bae-b3e1-73aa1edff47c@baylibre.com> Date: Sun, 12 Apr 2026 13:45:40 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC v2 8/9] Documentation: ABI: testing: add docs for ad9910 sysfs entries To: Jonathan Cameron , Rodrigo Alencar <455.rodrigo.alencar@gmail.com> Cc: Rodrigo Alencar via B4 Relay , rodrigo.alencar@analog.com, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, Lars-Peter Clausen , Michael Hennerich , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Philipp Zabel , Jonathan Corbet , Shuah Khan References: <20260318-ad9910-iio-driver-v2-0-e79f93becf11@analog.com> <20260318-ad9910-iio-driver-v2-8-e79f93becf11@analog.com> <20260322172257.1681de69@jic23-huawei> <20260412155115.2f7a83bf@jic23-huawei> Content-Language: en-US From: David Lechner In-Reply-To: <20260412155115.2f7a83bf@jic23-huawei> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 4/12/26 9:51 AM, Jonathan Cameron wrote: > On Mon, 23 Mar 2026 11:36:08 +0000 > Rodrigo Alencar <455.rodrigo.alencar@gmail.com> wrote: > >> On 26/03/22 05:22PM, Jonathan Cameron wrote: >>> On Wed, 18 Mar 2026 17:56:08 +0000 >>> Rodrigo Alencar via B4 Relay wrote: >>> >>>> From: Rodrigo Alencar >>>> >>>> Add ABI documentation file for the DDS AD9910 with sysfs entries to >>>> control Parallel Port, Digital Ramp Generator, RAM and OSK parameters. >>>> >>>> Signed-off-by: Rodrigo Alencar >>>> --- >> ... >>> >>>> + - "ramp_down": No-dwell low; the ramp resets to upper >>>> + limit upon reaching the lower limit. >>>> + - "ramp_up": No-dwell high; the ramp resets to lower >>>> + limit upon reaching the upper limit. >>>> + - "bidirectional_continuous": Both no-dwell high and low; >>>> + the ramp continuously sweeps without dwelling. >>> >>> Triangle wave? bidirectional continuous is a rather confusing term so maybe >>> we should rethink this one. >> >> Mostly yes, but not only that. Sawtooth can be achieved as well by changing >> the step sizes, also other weird patterns can be achieved by toggling DRCTL pin. > > Sawtooth is kind of a special triangle wave with one very steep side. > Wikipedia even has: "It can also be considered the extreme case of an asymmetric triangle wave" > https://en.wikipedia.org/wiki/Sawtooth_wave > >> This mode is the most useful when one does not have an FPGA and want to save >> resources on controlling the DRCTL pin. That mode name comes from the datasheet, >> so I suppose it was fine. > > Let us see if we can get more opinions on this. Whilst I can see the logic of > the datasheet naming, it's a bit obscure. > It is the same as ramp_up and ramp_down other than what happens when it hits the limit? If so, I would call it ramp_up_down.