From: Reinette Chatre <reinette.chatre@intel.com>
To: Ben Horgan <ben.horgan@arm.com>,
Richard Cheng <icheng@nvidia.com>, <tony.luck@intel.com>,
<x86@kernel.org>, <shuah@kernel.org>, <fenghuay@nvidia.com>
Cc: Dave.Martin@arm.com, james.morse@arm.com, babu.moger@amd.com,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
kaihengf@nvidia.com, kobak@nvidia.com, newtonl@nvidia.com,
kristinc@nvidia.com,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Subject: Re: [PATCH v5 2/2] selftests/resctrl: Recognise aarch64 as a vendor for L3_NONCONT_CAT
Date: Wed, 21 Oct 2026 07:56:19 -0700 [thread overview]
Message-ID: <801eeed4-6c31-40e7-8cfa-279d0740aa98@intel.com> (raw)
In-Reply-To: <415d1bf3-342d-45b5-b31e-ddc654510d85@arm.com>
Hi Ben,
On 10/20/26 9:18 AM, Ben Horgan wrote:
> On 12/10/2026 08:47, Richard Cheng wrote:
>> diff --git a/tools/testing/selftests/resctrl/cat_test.c b/tools/testing/selftests/resctrl/cat_test.c
>> index 0a417267dd74..f4b02b3eedd7 100644
>> --- a/tools/testing/selftests/resctrl/cat_test.c
>> +++ b/tools/testing/selftests/resctrl/cat_test.c
>> @@ -271,8 +271,13 @@ static bool arch_supports_noncont_cat(const struct resctrl_test *test)
>> {
>> unsigned int vendor_id = get_vendor();
>>
>> - /* AMD and Hygon always support non-contiguous CBM. */
>> - if (vendor_id == ARCH_AMD || vendor_id == ARCH_HYGON)
>> + /*
>> + * AMD and Hygon always support non-contiguous CBM. ARM/MPAM defines
>> + * MPAMCFG_CPBM as a bitmap with no contiguity constraint per ARM
>> + * DDI 0598.
>> + */
>> + if (vendor_id == ARCH_AMD || vendor_id == ARCH_HYGON ||
>> + vendor_id == ARCH_ARM)
>> return true;
>
> Would it be better not to just to use the information resctrl advertises?
> /sys/fs/resctrl/info/L3/sparse_masks
The result of this architecture specific test is used to validate that
/sys/fs/resctrl/info/L3/sparse_masks provides accurate information.
This test was originally developed on Intel where support for
sparse masks need to be discovered from the hardware.
>
> Is there any reason this test doesn't use that other than being written before its introduction?
Reinette
next prev parent reply other threads:[~2026-10-21 14:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-12 7:47 [PATCH v5 0/2] selftests/resctrl: Fix resctrl selftests issues on aarch64 Richard Cheng
2026-10-12 7:47 ` [PATCH v5 1/2] selftests/resctrl: Implement cl_flush() and sb() for aarch64 Richard Cheng
2026-10-20 16:30 ` Ben Horgan
2026-10-21 9:55 ` Ben Horgan
2026-10-12 7:47 ` [PATCH v5 2/2] selftests/resctrl: Recognise aarch64 as a vendor for L3_NONCONT_CAT Richard Cheng
2026-10-20 16:18 ` Ben Horgan
2026-10-21 14:56 ` Reinette Chatre [this message]
2026-10-12 22:09 ` [PATCH v5 0/2] selftests/resctrl: Fix resctrl selftests issues on aarch64 Reinette Chatre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=801eeed4-6c31-40e7-8cfa-279d0740aa98@intel.com \
--to=reinette.chatre@intel.com \
--cc=Dave.Martin@arm.com \
--cc=babu.moger@amd.com \
--cc=ben.horgan@arm.com \
--cc=fenghuay@nvidia.com \
--cc=icheng@nvidia.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=james.morse@arm.com \
--cc=kaihengf@nvidia.com \
--cc=kobak@nvidia.com \
--cc=kristinc@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=newtonl@nvidia.com \
--cc=shuah@kernel.org \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®