From: Antonio Borneo <antonio.borneo@foss.st.com>
To: Bjorn Andersson <andersson@kernel.org>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
<linux-remoteproc@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] hwspinlock: fix warning from sparse
Date: Wed, 25 Mar 2026 09:53:24 +0100 [thread overview]
Message-ID: <802412f7dfe45c9472d436e4c2c4babc76590894.camel@foss.st.com> (raw)
In-Reply-To: <20260323102210.228551-1-antonio.borneo@foss.st.com>
On Mon, 2026-03-23 at 11:22 +0100, Antonio Borneo wrote:
> Sparse triggers the following warnings:
>
> drivers/hwspinlock/hwspinlock_core.c:392:9: warning: incorrect type in assignment (different address spaces)
> drivers/hwspinlock/hwspinlock_core.c:392:9: expected void **slot
> drivers/hwspinlock/hwspinlock_core.c:392:9: got void [noderef] __rcu **
> drivers/hwspinlock/hwspinlock_core.c:392:9: warning: incorrect type in assignment (different address spaces)
> drivers/hwspinlock/hwspinlock_core.c:392:9: expected void **slot
> drivers/hwspinlock/hwspinlock_core.c:392:9: got void [noderef] __rcu **
> drivers/hwspinlock/hwspinlock_core.c:393:48: warning: incorrect type in argument 1 (different address spaces)
> drivers/hwspinlock/hwspinlock_core.c:393:48: expected void [noderef] __rcu **slot
> drivers/hwspinlock/hwspinlock_core.c:393:48: got void **slot
> drivers/hwspinlock/hwspinlock_core.c:397:30: warning: incorrect type in assignment (different address spaces)
> drivers/hwspinlock/hwspinlock_core.c:397:30: expected void **slot
> drivers/hwspinlock/hwspinlock_core.c:397:30: got void [noderef] __rcu **
> drivers/hwspinlock/hwspinlock_core.c:392:9: warning: incorrect type in argument 1 (different address spaces)
> drivers/hwspinlock/hwspinlock_core.c:392:9: expected void [noderef] __rcu **slot
> drivers/hwspinlock/hwspinlock_core.c:392:9: got void **slot
> drivers/hwspinlock/hwspinlock_core.c:392:9: warning: incorrect type in assignment (different address spaces)
> drivers/hwspinlock/hwspinlock_core.c:392:9: expected void **slot
> drivers/hwspinlock/hwspinlock_core.c:392:9: got void [noderef] __rcu **
>
> all linked to the same missing '__rcu' at declaration of 'slot'.
>
> Fix it!
>
> Signed-off-by: Antonio Borneo <antonio.borneo@foss.st.com>
> ---
> drivers/hwspinlock/hwspinlock_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwspinlock/hwspinlock_core.c b/drivers/hwspinlock/hwspinlock_core.c
> index cc8e952a67727..50a875b2353f8 100644
> --- a/drivers/hwspinlock/hwspinlock_core.c
> +++ b/drivers/hwspinlock/hwspinlock_core.c
> @@ -372,7 +372,7 @@ int of_hwspin_lock_get_id(struct device_node *np, int index)
> struct of_phandle_args args;
> struct hwspinlock *hwlock;
> struct radix_tree_iter iter;
> - void **slot;
> + void __rcu **slot;
Please ignore this patch.
While it fixes a minor warning from sparse, the analysis in
http://sashiko.dev/#/patchset/20260323102210.228551-1-antonio.borneo%40foss.st.com
highlights a race if provider is unbind, plus I see another race between provider and consumer on async probe.
I'm checking to fix such races, addressing at the same time the warning from sparse.
Merging this patch now will only create unnecessary dependency for backporting in stable.
Regards,
Antonio
prev parent reply other threads:[~2026-03-25 8:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-23 10:22 Antonio Borneo
2026-03-25 8:53 ` Antonio Borneo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=802412f7dfe45c9472d436e4c2c4babc76590894.camel@foss.st.com \
--to=antonio.borneo@foss.st.com \
--cc=andersson@kernel.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®