From: Josef Bacik <josef@toxicpanda.com>
To: Linus Torvalds <torvalds@linux-foundation.org>,
Dave Jones <davej@codemonkey.org.uk>,
Filipe Manana <fdmanana@suse.com>,
David Sterba <dsterba@suse.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Linux 5.6-rc2
Date: Sun, 16 Feb 2020 22:02:01 -0500 [thread overview]
Message-ID: <8025e1bf-4834-83c6-d12c-4e817f875776@toxicpanda.com> (raw)
In-Reply-To: <CAHk-=wg5AkQk-9By-QeyT+5H_t6DLZD=25uOz-ujnV8oEv1Y5Q@mail.gmail.com>
On 2/16/20 9:24 PM, Linus Torvalds wrote:
> On Sun, Feb 16, 2020 at 6:08 PM Dave Jones <davej@codemonkey.org.uk> wrote:
>>
>> This didn't happen in rc1, but showed up when I booted into rc2 and
>> tried to and pull some stuff with rsync.
>>
>> [ 70.794783] BUG: sleeping function called from invalid context at mm/slab.h:565
>> [ 70.795459] kmem_cache_alloc+0x1d3/0x290
>> [ 70.795471] alloc_extent_state+0x22/0x1c0
>> [ 70.795544] __clear_extent_bit+0x3ba/0x580
>> [ 70.795569] btrfs_truncate_inode_items+0x339/0xe50
>> [ 70.795647] btrfs_evict_inode+0x269/0x540
>
> At a guess (just by functions involved, and the timing between rc1 and
> rc2 - no actual analysis), this is probably due to
>
> 28553fa992cb ("Btrfs: fix race between shrinking truncate and fiemap")
>
> which is also marked for stable, so... Filipe?
>
I assume Filipe wrote this based on my patch here
https://git.kernel.org/pub/scm/linux/kernel/git/josef/btrfs-next.git/commit/?id=c821555d2b9733d8f483c9e79481c7209e1c1fb0
which makes it so we can allocate safely in this context, but that patch hasn't
made it's way to you yet. Do you want it now? It was prep for a much less safe
patchset, but is fine by itself. Thanks,
Josef
next prev parent reply other threads:[~2020-02-17 3:02 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-16 21:32 Linus Torvalds
2020-02-17 2:08 ` Dave Jones
2020-02-17 2:24 ` Linus Torvalds
2020-02-17 3:02 ` Josef Bacik [this message]
2020-02-17 5:08 ` Linus Torvalds
2020-02-17 12:30 ` David Sterba
2020-02-17 16:45 ` Dave Jones
2020-02-17 16:04 ` Filipe Manana
2020-02-17 16:21 ` Chris Wilson
2020-02-17 21:20 ` Linus Torvalds
2020-02-17 21:29 ` Chris Wilson
2020-02-20 22:41 ` Rafael J. Wysocki
2020-02-21 0:46 ` Rafael J. Wysocki
2020-02-21 9:19 ` Chris Wilson
[not found] ` <CAJZ5v0h07em8y5bXcnUTBcjie8pCttADK9QX9W_cB0WQRcDfGQ@mail.gmail.com>
2020-02-21 18:02 ` Linus Torvalds
2020-02-23 23:57 ` Rafael J. Wysocki
2020-02-17 18:42 ` sinisa
2020-02-17 20:17 ` Dominik Brodowski
2020-02-21 1:38 ` Dave Airlie
2020-02-21 2:23 ` [Intel-gfx] " Souza, Jose
2020-02-24 18:24 ` Siniša Bandin
2020-03-02 16:39 ` Siniša Bandin
2020-03-02 17:04 ` Jani Nikula
2020-03-03 7:08 ` Sinisa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8025e1bf-4834-83c6-d12c-4e817f875776@toxicpanda.com \
--to=josef@toxicpanda.com \
--cc=davej@codemonkey.org.uk \
--cc=dsterba@suse.com \
--cc=fdmanana@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®