From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759348AbdACO3g (ORCPT ); Tue, 3 Jan 2017 09:29:36 -0500 Received: from mga06.intel.com ([134.134.136.31]:18843 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752832AbdACO3d (ORCPT ); Tue, 3 Jan 2017 09:29:33 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,455,1477983600"; d="scan'208";a="804647514" Subject: Re: [PATCH v2] mmc: sdhci-cadence: add Socionext UniPhier specific compatible string To: Masahiro Yamada , linux-mmc@vger.kernel.org References: <1481681446-29832-1-git-send-email-yamada.masahiro@socionext.com> Cc: Rob Herring , Ulf Hansson , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Herring , Mark Rutland From: Adrian Hunter Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki Message-ID: <8026e36e-7e21-9c8f-fe9e-77bc9eae6d51@intel.com> Date: Tue, 3 Jan 2017 16:24:22 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <1481681446-29832-1-git-send-email-yamada.masahiro@socionext.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14/12/16 04:10, Masahiro Yamada wrote: > Add a Socionext SoC specific compatible (suggested by Rob Herring). > > No SoC specific data are associated with the compatible strings for > now, but other SoC vendors may use this IP and want to differentiate > IP variants in the future. > > Signed-off-by: Masahiro Yamada For sdhci: Acked-by: Adrian Hunter > --- > > Changes in v2: > - Add "uniphier" to the compatible to make it more SoC-specific > > Documentation/devicetree/bindings/mmc/sdhci-cadence.txt | 6 ++++-- > drivers/mmc/host/sdhci-cadence.c | 1 + > 2 files changed, 5 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/mmc/sdhci-cadence.txt b/Documentation/devicetree/bindings/mmc/sdhci-cadence.txt > index 750374f..c0f37cb 100644 > --- a/Documentation/devicetree/bindings/mmc/sdhci-cadence.txt > +++ b/Documentation/devicetree/bindings/mmc/sdhci-cadence.txt > @@ -1,7 +1,9 @@ > * Cadence SD/SDIO/eMMC Host Controller > > Required properties: > -- compatible: should be "cdns,sd4hc". > +- compatible: should be one of the following: > + "cdns,sd4hc" - default of the IP > + "socionext,uniphier-sd4hc" - for Socionext UniPhier SoCs > - reg: offset and length of the register set for the device. > - interrupts: a single interrupt specifier. > - clocks: phandle to the input clock. > @@ -19,7 +21,7 @@ if supported. See mmc.txt for details. > > Example: > emmc: sdhci@5a000000 { > - compatible = "cdns,sd4hc"; > + compatible = "socionext,uniphier-sd4hc", "cdns,sd4hc"; > reg = <0x5a000000 0x400>; > interrupts = <0 78 4>; > clocks = <&clk 4>; > diff --git a/drivers/mmc/host/sdhci-cadence.c b/drivers/mmc/host/sdhci-cadence.c > index 1501cfd..4b0ecb9 100644 > --- a/drivers/mmc/host/sdhci-cadence.c > +++ b/drivers/mmc/host/sdhci-cadence.c > @@ -262,6 +262,7 @@ static int sdhci_cdns_probe(struct platform_device *pdev) > } > > static const struct of_device_id sdhci_cdns_match[] = { > + { .compatible = "socionext,uniphier-sd4hc" }, > { .compatible = "cdns,sd4hc" }, > { /* sentinel */ } > }; >