From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6189C388F7 for ; Sun, 25 Oct 2020 08:38:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A3F40208B3 for ; Sun, 25 Oct 2020 08:38:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1768303AbgJYIiT (ORCPT ); Sun, 25 Oct 2020 04:38:19 -0400 Received: from smtprelay0209.hostedemail.com ([216.40.44.209]:57292 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1766553AbgJYIiS (ORCPT ); Sun, 25 Oct 2020 04:38:18 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay01.hostedemail.com (Postfix) with ESMTP id D8951100E7B42; Sun, 25 Oct 2020 08:38:16 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: toys59_36154d427269 X-Filterd-Recvd-Size: 1384 Received: from XPS-9350.home (unknown [47.151.133.149]) (Authenticated sender: joe@perches.com) by omf05.hostedemail.com (Postfix) with ESMTPA; Sun, 25 Oct 2020 08:38:15 +0000 (UTC) Message-ID: <80280a389782858c72fcd56a54da1a1f4153216c.camel@perches.com> Subject: Re: [PATCH v4] checkpatch: extend attributes check to handle more patterns From: Joe Perches To: Dwaipayan Ray Cc: linux-kernel-mentees@lists.linuxfoundation.org, linux-kernel , Lukas Bulwahn Date: Sun, 25 Oct 2020 01:38:14 -0700 In-Reply-To: References: <20201025065134.21737-1-dwaipayanray1@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.38.1-1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2020-10-25 at 14:02 +0530, Dwaipayan Ray wrote: > And also do you think there should be a separate check > for __alias__(#symbol)? I think it expects a string and that should > be trimmed in the fix. For now, I think you should avoid both alias and section. There are patches to convert both of these macros to remove the stringify.