From: Lukasz Luba <lukasz.luba@arm.com>
To: Vincent Guittot <vincent.guittot@linaro.org>
Cc: Dietmar Eggemann <dietmar.eggemann@arm.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
"open list:THERMAL" <linux-pm@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Viresh Kumar <viresh.kumar@linaro.org>,
Quentin Perret <qperret@google.com>,
Vincent Donnefort <vincent.donnefort@arm.com>,
Beata Michalska <Beata.Michalska@arm.com>,
Ingo Molnar <mingo@redhat.com>,
Juri Lelli <juri.lelli@redhat.com>,
Steven Rostedt <rostedt@goodmis.org>,
segall@google.com, Mel Gorman <mgorman@suse.de>,
Daniel Bristot de Oliveira <bristot@redhat.com>
Subject: Re: [PATCH v2 1/2] sched/fair: Take thermal pressure into account while estimating energy
Date: Thu, 10 Jun 2021 13:53:15 +0100 [thread overview]
Message-ID: <80283949-8a07-5aed-1e56-0a1094ba3ba0@arm.com> (raw)
In-Reply-To: <CAKfTPtBD2qa3qwpoLuLNuF-hZAGpDvsahx6Tx_enLT2DAs4fiQ@mail.gmail.com>
On 6/10/21 1:40 PM, Vincent Guittot wrote:
> On Thu, 10 Jun 2021 at 14:30, Lukasz Luba <lukasz.luba@arm.com> wrote:
[snip]
>>
>> So for this scenario, where we want to just align EAS with SchedUtil
>> frequency decision, which is instantaneous and has 'raw' value
>> of capping from policy->max, shouldn't we use:
>>
>> thermal_pressure = arch_scale_thermal_pressure(cpu_id)
>
> Yes you should probably use arch_scale_thermal_pressure(cpu) instead
> of thermal_load_avg(rq) in this case
>
Thank you Vincent for valuable opinions!
I will rewrite it and experiment with a new approach,
then send a v3.
Regards,
Lukasz
next prev parent reply other threads:[~2021-06-10 12:53 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-04 8:09 [PATCH v2 0/2] Add allowed CPU capacity knowledge to EAS Lukasz Luba
2021-06-04 8:09 ` [PATCH v2 1/2] sched/fair: Take thermal pressure into account while estimating energy Lukasz Luba
2021-06-10 7:59 ` Vincent Guittot
2021-06-10 8:42 ` Lukasz Luba
2021-06-10 9:11 ` Vincent Guittot
2021-06-10 9:36 ` Lukasz Luba
2021-06-10 9:41 ` Vincent Guittot
2021-06-10 9:52 ` Lukasz Luba
2021-06-10 9:45 ` Vincent Guittot
2021-06-10 8:42 ` Dietmar Eggemann
2021-06-10 9:04 ` Lukasz Luba
2021-06-10 10:07 ` Dietmar Eggemann
2021-06-10 10:37 ` Lukasz Luba
2021-06-10 12:19 ` Vincent Guittot
2021-06-10 12:30 ` Lukasz Luba
2021-06-10 12:40 ` Vincent Guittot
2021-06-10 12:53 ` Lukasz Luba [this message]
2021-06-04 8:09 ` [PATCH v2 2/2] sched/cpufreq: Consider reduced CPU capacity in energy calculation Lukasz Luba
2021-06-09 15:01 ` Rafael J. Wysocki
2021-06-10 8:19 ` Lukasz Luba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=80283949-8a07-5aed-1e56-0a1094ba3ba0@arm.com \
--to=lukasz.luba@arm.com \
--cc=Beata.Michalska@arm.com \
--cc=bristot@redhat.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=qperret@google.com \
--cc=rjw@rjwysocki.net \
--cc=rostedt@goodmis.org \
--cc=segall@google.com \
--cc=vincent.donnefort@arm.com \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®