From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from courrier.aliel.fr (pouet.aliel.fr [65.21.61.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DB83630E85D; Thu, 26 Mar 2026 09:27:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=65.21.61.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774517280; cv=none; b=BMuEu7QbtapL5ugjrsD/FJelThMIpseSBag7IGJ68BiuVMOPlUfivzaa40c038Xv8Lg/E7Pmv3j2gg2Uc6/URJNaRYC9gBxG0A9KjDV59IijGJGlEAHDI1maUMEEVN4KJPWfN0Lp9Ka/TZ6KLfQ3XW63q12OcVrkN9SVs+2bWDw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774517280; c=relaxed/simple; bh=hCffSrytymkZsTF+g18yVFG0ugDdfGbOo15ZfjxCRlA=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=oi/QB8bQGg/UqNW+U0Ie9NRkSRawe16hQdxcIZVWKllR3TMJ2BKyafPJSNK/Tv0HvgBUlisBlpkEWk+HlLpnPZHEokiLSqDoWxIsWZDFfLXDKuA32ChaNJfXPVPYCaJZv/Zd+zgOSPmcQi0FcpgvUG/BprcUOhbDjupeqyjod1U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=aliel.fr; spf=pass smtp.mailfrom=aliel.fr; dkim=pass (1024-bit key) header.d=aliel.fr header.i=@aliel.fr header.b=eQ3/7Ykj; arc=none smtp.client-ip=65.21.61.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=aliel.fr Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=aliel.fr Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=aliel.fr header.i=@aliel.fr header.b="eQ3/7Ykj" Message-ID: <802bc778-9e18-4273-9757-c0d663e8b14a@aliel.fr> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=aliel.fr; s=courrier-s1; t=1774517276; bh=hCffSrytymkZsTF+g18yVFG0ugDdfGbOo15ZfjxCRlA=; h=Date:From:Subject:To:Cc:References:In-Reply-To; b=eQ3/7Ykj9LCvsbKYSiqPnT9GfUx9Eyibc77/pFGLIy68mfwchsIIBIA4mt1YpPzMX qzJhnNCu+i0VUh5RXafyaHWePHRsm3BCaZsY6YTN8ZRBwHqCqzovwcig9uJMe0TfqI xvgmxbihm57B90MJpQ3wb+JUn+BMn80mc8QgNLa4= Date: Thu, 26 Mar 2026 10:27:54 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta From: Ronald Claveau Subject: Re: [PATCH v4 9/9] arm64: dts: amlogic: t7: khadas-vim4: Add MMC nodes To: Neil Armstrong Cc: linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org, linux-wireless@vger.kernel.org, Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Ulf Hansson , Johannes Berg , van Spriel References: <20260325-add-emmc-t7-vim4-v4-0-44c7b4a5e459@aliel.fr> <20260325-add-emmc-t7-vim4-v4-9-44c7b4a5e459@aliel.fr> <512d95b5-5348-4c7c-961c-b6ca1431cee4@linaro.org> Content-Language: en-US In-Reply-To: <512d95b5-5348-4c7c-961c-b6ca1431cee4@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 3/26/26 9:54 AM, Neil Armstrong wrote: > On 3/25/26 10:15, Ronald Claveau wrote: >> Enable and configure the three MMC controllers for the Khadas VIM4 board: >> - sd_emmc_a: SDIO interface for the BCM43752 Wi-Fi module >> - sd_emmc_b: SD card slot >> - sd_emmc_c: eMMC storage >> >> Signed-off-by: Ronald Claveau >> --- >>   .../dts/amlogic/amlogic-t7-a311d2-khadas-vim4.dts  | 90 ++++++++++++ >> +++++++++- >>   1 file changed, 89 insertions(+), 1 deletion(-) >> >> diff --git a/arch/arm64/boot/dts/amlogic/amlogic-t7-a311d2-khadas- >> vim4.dts b/arch/arm64/boot/dts/amlogic/amlogic-t7-a311d2-khadas-vim4.dts >> index 770f06b0b16c7..5a73ae081036c 100644 >> --- a/arch/arm64/boot/dts/amlogic/amlogic-t7-a311d2-khadas-vim4.dts >> +++ b/arch/arm64/boot/dts/amlogic/amlogic-t7-a311d2-khadas-vim4.dts >> @@ -14,7 +14,10 @@ / { >>       compatible = "khadas,vim4", "amlogic,a311d2", "amlogic,t7"; >>         aliases { >> -        serial0 = &uart_a; >> +        serial0    = &uart_a; > > Spurious change > Thanks I will keep space instead of tab here. >> +        mmc0    = &sd_emmc_c; >> +        mmc1    = &sd_emmc_b; >> +        mmc2    = &sd_emmc_a; >>       }; >>         memory@0 { >> @@ -159,6 +162,91 @@ &pwm_ab { >>       pinctrl-names = "default"; >>   }; >>   +/* SDIO */ >> +&sd_emmc_a { >> +    status = "okay"; >> +    pinctrl-0 = <&sdio_pins>; >> +    pinctrl-1 = <&sdio_clk_gate_pins>; >> +    pinctrl-names = "default", "clk-gate"; >> +    #address-cells = <1>; >> +    #size-cells = <0>; >> + >> +    bus-width = <4>; >> +    cap-sd-highspeed; >> +    sd-uhs-sdr12; >> +    sd-uhs-sdr25; >> +    sd-uhs-sdr50; >> +    sd-uhs-sdr104; >> +    cap-sdio-irq; >> +    max-frequency = <200000000>; >> +    non-removable; >> +    disable-wp; >> +    no-mmc; >> +    no-sd; >> + >> +    power-domains = <&pwrc PWRC_T7_SDIO_A_ID>; >> + >> +    keep-power-in-suspend; >> + >> +    mmc-pwrseq = <&sdio_pwrseq>; >> + >> +    vmmc-supply = <&vddao_3v3>; >> +    vqmmc-supply = <&vddao_1v8>; >> + >> +    brcmf: wifi@1 { >> +        reg = <1>; >> +        compatible = "brcm,bcm43752-fmac", "brcm,bcm4329-fmac"; >> +    }; >> +}; >> + >> +/* SD card */ >> +&sd_emmc_b { >> +    status = "okay"; >> +    pinctrl-0 = <&sdcard_pins>; >> +    pinctrl-1 = <&sdcard_clk_gate_pins>; >> +    pinctrl-names = "default", "clk-gate"; >> + >> +    bus-width = <4>; >> +    cap-sd-highspeed; >> +    sd-uhs-sdr12; >> +    sd-uhs-sdr25; >> +    sd-uhs-sdr50; >> +    sd-uhs-sdr104; >> +    max-frequency = <200000000>; >> +    disable-wp; >> +    no-sdio; >> +    no-mmc; >> + >> +    power-domains = <&pwrc PWRC_T7_SDIO_B_ID>; >> + >> +    cd-gpios = <&gpio GPIOC_6 GPIO_ACTIVE_LOW>; >> +    vmmc-supply = <&sd_3v3>; >> +    vqmmc-supply = <&vddio_c>; >> +}; >> + >> +/* eMMC */ >> +&sd_emmc_c { >> +    status = "okay"; >> +    pinctrl-0 = <&emmc_ctrl_pins>, <&emmc_data_8b_pins>, >> <&emmc_ds_pins>; >> +    pinctrl-1 = <&emmc_clk_gate_pins>; >> +    pinctrl-names = "default", "clk-gate"; >> + >> +    bus-width = <8>; >> +    cap-mmc-highspeed; >> +    mmc-ddr-1_8v; >> +    mmc-hs200-1_8v; >> +    max-frequency = <200000000>; >> +    disable-wp; >> +    non-removable; >> +    no-sdio; >> +    no-sd; >> + >> +    power-domains = <&pwrc PWRC_T7_EMMC_ID>; >> + >> +    vmmc-supply = <&vddio_3v3>; >> +    vqmmc-supply = <&vddio_1v8>; >> +}; >> + >>   &uart_a { >>       status = "okay"; >>       clocks = <&xtal>, <&xtal>, <&xtal>; >> > > With that: > > Reviewed-by: Neil Armstrong > > Thanks, > Neil -- Best regards, Ronald