From: Jens Axboe <axboe@kernel.dk>
To: Christoph Hellwig <hch@lst.de>
Cc: torvalds@linuxfoundation.org, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] block: remove CONFIG_LBDAF
Date: Fri, 5 Apr 2019 12:00:57 -0600 [thread overview]
Message-ID: <802e6ae2-40b2-8f46-fe9f-1277bf55d50f@kernel.dk> (raw)
In-Reply-To: <20190405160859.5288-1-hch@lst.de>
On 4/5/19 10:08 AM, Christoph Hellwig wrote:
> Currently support for 64-bit sector_t and blkcnt_t is optional on 32-bit
> architectures. These types are required to support block device and/or
> file sizes larger than 2 TiB, and have generally defaulted to on for
> a long time. Enabling the option only increases the i386 tinyconfig
> size by 145 bytes, and many data structures already always use
> 64-bit values for their in-core and on-disk data structures anyway,
> so there should not be a large change in dynamic memory usage either.
>
> Dropping this option removes a somewhat weird non-default config that
> has cause various bugs or compiler warnings when actually used.
I'm greatly in favor of this - but can we drop the defconfig changes?
Not strictly needed, it's not like they will cause issues with the
symbol still being there.
--
Jens Axboe
next prev parent reply other threads:[~2019-04-05 18:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-05 16:08 Christoph Hellwig
2019-04-05 18:00 ` Jens Axboe [this message]
2019-04-06 16:30 ` Linus Torvalds
2019-04-06 16:48 ` Jens Axboe
2019-04-08 8:30 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=802e6ae2-40b2-8f46-fe9f-1277bf55d50f@kernel.dk \
--to=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome