From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D7F6B38F938 for ; Tue, 11 Aug 2026 02:24:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786415101; cv=none; b=TUs5YiEBBtWRNftpxaWis46/LNGJkaBswQarJOBSRWtf6A/UfqnXgW4kmIepqHFIMeWESE7usDTa8OrjjrCjHtAMDEN6zkJAM5vhe/w1jN6YlYGqUdbe+7EtoomO92du8rlDejZcMkNqCMk6SNlQfxoopBI9SXIehVR0C6s3Jtk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786415101; c=relaxed/simple; bh=acyPGfylUMzsKpzfgGBSv02dZSe8KVU49lqM2DmPcqQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=hOzt70fJvodd976/8UeLUkJ/0X3zZfBbgn9r72QMFexzf+lJZ5BVpJw0s61oFEUB5LQVMZWxApvmzuQ6AqWQxOVs70s9nEBW+od1bQCTF4bc3jP/m7nHq3EDHXWlboemq4dXY5I/sbMqoVUprYLtwc+IMai2wyZPbmRj5Ft5mkc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ejlp7fo2; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ZWs6ulxj; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ejlp7fo2"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ZWs6ulxj" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67AMqKP33307997 for ; Tue, 11 Aug 2026 02:24:52 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= YXcNHLM8qGDWKTk4CUAODcEzd7LuZQzNNK3A3gJgByw=; b=ejlp7fo2heYmwlTO BhG7C+41Q1Whx29+t2+ZTyZ+/fVopS5KuK3sZgjkRDRnVzfX+hxlOphOvX1AUj4L Uxme4uQK5man0jm1MfP/WdXxc5n1eQJfGlfzgqbCyXLkmE0HnzHFo9Sq3KESm3tO cqDfhu9K9xNbvVRXmah4NyG7UG6Yy+Nbo9egECDSb7iArIjK+1ywKRELWluJmByX NyC57vRO3Wov8oacVninuFMoVcdDeRxNRVsMbV38OvjWnIVi1ZP4SxbIHP3Qlzj8 weKxrEP7cwURQVH8BTn99UvZyNLLHuuXLMZzmgVs01ULxNC8TmYeX3y5rjxrmAoL cxoo+Q== Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fyjyfsux6-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 11 Aug 2026 02:24:52 +0000 (GMT) Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-38ec0f510a9so6524038a91.2 for ; Mon, 10 Aug 2026 19:24:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786415092; x=1787019892; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to:content-type; bh=YXcNHLM8qGDWKTk4CUAODcEzd7LuZQzNNK3A3gJgByw=; b=ZWs6ulxjfcRe8aTwNUXZeS291EtIgFmMA/4m+bxGcNXsynEZ8Gl06MtO/MiFtmD8Z9 GsLlkCRkUMyO1f/9auqW1lU8s/HggVTXM2TJSXQ1bFisOvxrgb3SSKbJ9KYNTEWMFmRn PMRouZXsrM1t823L3HUnSskejkNGYnDetiT54skidq+UmdtV4rtgwfYY4VV8xDUh5rYM 7S3GzPrQCorZR/zQCeoKPo5p5l/3QkEMaifRRRqzwVsvnoOYL91MGriylsaFhqXh6S0l B2jWyB0SC9kiRm+u7R1w/avbeAr8XFp15Pjz/se2FrzhhoxZmCZMr07VTNz510a4M5QN 5zyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786415092; x=1787019892; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=YXcNHLM8qGDWKTk4CUAODcEzd7LuZQzNNK3A3gJgByw=; b=ZCDpK2NVy94LwSFfzny1ZcQer4kCiA14buU4vxIjfOfxrs0GAkq2nd0XoNErafWvTZ zukFZkW5X8ptDwgvRscfcCJrPvV/zstfJIv6CSKcxiDAPpdkZOlPRg5A1nweVl+460IN CUQ8zl4zvtoViU7H959fW6tClXcOCjv9K37/4AH54arZD95rOkg3mktsw5eBXvHJSigh KdwLlNeHA90duG+IwOsOTvbzp5LPUk6+HQbf+OfRJRv2FHICN/crEuLONxaaJDR5iBla 7PtLxwIHgkcaCDk+qeHB0vCLKrKq6ei7oYpx7TamnjxXK4275RwewkWNg0M2Wq2oUEiM +vsw== X-Forwarded-Encrypted: i=1; AHgh+RrOzJqS66P2nzHwXJdwRqRKuntG593s27UHzEn8v65mI2jkxQ4awttTZgpUqlPIBsHw/JhtsC2XgJF+TuI=@vger.kernel.org X-Gm-Message-State: AOJu0Yxd4ORQJTsFCgJ0SuI3VIq7F+Xpyj/+CyZYY30Sy+TNW7MLrMX+ rYzX/qSAyAknQTEDWNjcmDu5lpvm/ErgxNKVJFQQ9vu0wv9L4rGLSlhb5IlDFaK9t/0HNFvVOG3 O7Bl8IKl0kNBkBrHqPi8ZjFlC0vp7dQk+0GBo7LvzzvxPAzcTDvI+9R5pYWUkAdJfAjqgsrDBvF 3agA== X-Gm-Gg: AR+sD11PVmth+2LQPIkWdRK7TLudDwKGuiYYzo1zx4+bxdqpqLhpRGOcnb/JXEB0w+q 1QXINzSIJ1lrjMAMK5G6JcB/O/8ipWwZmtDbZEdOmKdV6t+6Gu7/+b1slcRmtI7OJDpG1DWKwqS swCFvKipRwSslwUJdE3UxupCWK5jW+VAZd8f28hPWBlfeRKodQAideS1bqDYkkm+0Gobirr+oJQ rVxBAClt8wepPkBlBp8Rt+DeFdOdBEC/hYmxvruxVYWc8u3VOvwqb8pJ8Do29a0f+SzFAl+h9i9 O01tyelopuh+4WIKIU/p/GgodCmLo3sJLSuCTslggQTmHnCnVZAfcIuUAetipWQbYTQt2N28bL7 29DBty8pTQ+j0cbk9RNLoP/TjP9UKYzHQpXMkAEaU3mxBdZBBvbpRiZbrpz9jl81/TCZm+gXs X-Received: by 2002:a17:90b:288d:b0:38f:26c7:165e with SMTP id 98e67ed59e1d1-39261ff3945mr33151671a91.9.1786415091798; Mon, 10 Aug 2026 19:24:51 -0700 (PDT) X-Received: by 2002:a17:90b:288d:b0:38f:26c7:165e with SMTP id 98e67ed59e1d1-39261ff3945mr33151621a91.9.1786415091338; Mon, 10 Aug 2026 19:24:51 -0700 (PDT) Received: from [10.133.33.43] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-392d5195a4dsm1613157a91.4.2026.08.10.19.24.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 Aug 2026 19:24:50 -0700 (PDT) Message-ID: <802e92d2-b1be-4a0d-bb3c-93b9e510c9d5@oss.qualcomm.com> Date: Tue, 11 Aug 2026 10:24:46 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] ath11k: modify null check logic in ath11k_ce_rx_post_pipe() To: Mikhail Lobanov , Kalle Valo Cc: Jeff Johnson , Govindaraj Saminathan , Miles Hu , Sven Eckelmann , Rajkumar Manoharan , John Crispin , linux-wireless@vger.kernel.org, ath11k@lists.infradead.org, linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org References: <20240909150824.28195-1-m.lobanov@rosalinux.ru> From: Baochen Qiang Content-Language: en-US In-Reply-To: <20240909150824.28195-1-m.lobanov@rosalinux.ru> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: lFvY0GFAfntVSlO3-lC4ktYCIY3BiOMu X-Proofpoint-Spam-Info: AW1haW4tMjYwODExMDAxNyBTYWx0ZWRfXxDDbh1h7jnIH DlJ+Pn6h62Y/cnGamZKWuj3s6c3m8sgVbSrq11lVbS0JqJoULYvQCwJ7SyWy0Cqn6JzvPKH9fcx uUp7bnxIvBRjHQUhvJizLl10D/76uFQ= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODExMDAxNyBTYWx0ZWRfXyKYuNy9kYlnR hXIJgIS9yuZWJKLVcrYE2hTCDTCLVcMtJVo8dkmP2RzKaUjjDNzDNVx9RyfyfyqACe8HkSnFnme Ru73oWy/JO58BtcvyJGFQklLHQn8fvT20Ay7zzhhgrngw82Fbt6YwKIUJSw5LN7f7GWr74wweJQ y0T1Kx1GBsYuCqvF+oK7soiwtVzpd0//brLilHFyIc22CxLQtCgKg1YyG0abWQUC/jowLaDhUOq 23OcuWTkZgf4Zq2cxUmUyZl3KJiV/PY/7g+rsX917+Srv+vn451QQ5DPIZfgUjXQiB/CIoTF5+g UCVmQutkJXQFg9ha6wjGJHICAbSxAMFXk6YipTjxgoXKLMZdkzf12AzQAqtYtPbuGUPJcjvfUzf ssf3oxAfvAFdKEMibLMKIoppC9jMljCXsGpt4UHF2z1CP4Vi3k9LZiEUE1vHVyXZUlfMsw35yxB PmT+NH3hzXp5W9SNGWQ== X-Proofpoint-GUID: lFvY0GFAfntVSlO3-lC4ktYCIY3BiOMu X-Authority-Analysis: v=2.4 cv=Zd4t8MVA c=1 sm=1 tr=0 ts=6a7a87f4 cx=c_pps a=0uOsjrqzRL749jD1oC5vDA==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=HH5vDtPzAAAA:8 a=he8YDqbjAAAA:8 a=EUspDBNiAAAA:8 a=e4nBh9WiceBO0ho2o1YA:9 a=QEXdDO2ut3YA:10 a=mQ_c8vxmzFEMiUWkPHU9:22 a=QM_-zKB-Ew0MsOlNKMB5:22 a=lRF3faHqDRKgy28aj_NN:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-10_06,2026-08-10_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 impostorscore=0 malwarescore=0 suspectscore=0 adultscore=0 priorityscore=1501 spamscore=0 phishscore=0 bulkscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608110017 On 9/9/2024 11:08 PM, Mikhail Lobanov wrote: > The previous logic in ath11k_ce_rx_post_pipe() incorrectly required both > dest_ring and status_ring to be NULL in order to exit the function. > This caused the function to continue even if only one of the pointers > was NULL, potentially leading to null pointer dereferences in > ath11k_ce_rx_buf_enqueue_pipe(). > > Fix the condition by modifying the logic so that the function returns > early if either dest_ring or status_ring is NULL. > > Found by Linux Verification Center (linuxtesting.org) with SVACE. > > Fixes: d5c65159f289 ("ath11k: driver for Qualcomm IEEE 802.11ax devices") > Signed-off-by: Mikhail Lobanov > --- > drivers/net/wireless/ath/ath11k/ce.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/ath/ath11k/ce.c b/drivers/net/wireless/ath/ath11k/ce.c > index e66e86bdec20..9d4246d65d68 100644 > --- a/drivers/net/wireless/ath/ath11k/ce.c > +++ b/drivers/net/wireless/ath/ath11k/ce.c > @@ -324,7 +324,7 @@ static int ath11k_ce_rx_post_pipe(struct ath11k_ce_pipe *pipe) > dma_addr_t paddr; > int ret = 0; > > - if (!(pipe->dest_ring || pipe->status_ring)) > + if (!pipe->dest_ring || !pipe->status_ring) > return 0; > > spin_lock_bh(&ab->ce.ce_lock); Reviewed-by: Baochen Qiang