From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751673AbdBBWNN (ORCPT <rfc822;w@1wt.eu>);
        Thu, 2 Feb 2017 17:13:13 -0500
Received: from mail-pg0-f52.google.com ([74.125.83.52]:34196 "EHLO
        mail-pg0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751446AbdBBWNM (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 2 Feb 2017 17:13:12 -0500
Subject: Re: [PATCH v4 2nd 1/4] ramoops: Add __ramoops_init_prz() as generic
 function
To: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.kw@hitachi.com>,
        Anton Vorontsov <anton@enomsg.org>, Colin Cross <ccross@android.com>,
        Kees Cook <keescook@chromium.org>, Tony Luck <tony.luck@intel.com>
References: <1485827915-9620-1-git-send-email-nobuhiro.iwamatsu.kw@hitachi.com>
 <1485827915-9620-2-git-send-email-nobuhiro.iwamatsu.kw@hitachi.com>
Cc: linux-kernel@vger.kernel.org,
        Hiraku Toyooka <hiraku.toyooka.gu@hitachi.com>,
        Seiji Aguchi <seiji.aguchi.tr@hitachi.com>,
        Shuah Khan <shuahkh@osg.samsung.com>
From: Mark Salyzyn <salyzyn@android.com>
Message-ID: <8035b840-8f84-35c4-60e7-5d1c4c8e9b5f@android.com>
Date: Thu, 2 Feb 2017 14:13:09 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.5.1
MIME-Version: 1.0
In-Reply-To: <1485827915-9620-2-git-send-email-nobuhiro.iwamatsu.kw@hitachi.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 01/30/2017 05:58 PM, Nobuhiro Iwamatsu wrote:
> +
> +	if (zap && *paddr + sz - cxt->phys_addr > cxt->size) {
> +		dev_err(dev, "no room for %s mem region (0x%zx@0x%llx) in (0x%lx@0x%llx)\n",
> +			name, sz, (unsigned long long)*paddr,
> +			cxt->size, (unsigned long long)cxt->phys_addr);
> +		return -ENOMEM;
> +	}
> +
Why not allow this limit check for ramoops_init_prsz call?

-- Mark