From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1948609AbcBSLq4 (ORCPT ); Fri, 19 Feb 2016 06:46:56 -0500 Received: from rtits2.realtek.com ([60.250.210.242]:57026 "EHLO rtits2.realtek.com.tw" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1948581AbcBSLqw convert rfc822-to-8bit (ORCPT ); Fri, 19 Feb 2016 06:46:52 -0500 Authenticated-By: From: Hau To: Francois Romieu CC: "netdev@vger.kernel.org" , nic_swsd , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH net] r8169:fix "rtl_counters_cond == 1 (loop: 1000, delay: 10)" log spam. Thread-Topic: [PATCH net] r8169:fix "rtl_counters_cond == 1 (loop: 1000, delay: 10)" log spam. Thread-Index: AQHRalymd9FMb4ZR+ke2u4GPYJMnsJ8xvOoAgAGCVGA= Date: Fri, 19 Feb 2016 11:46:43 +0000 Message-ID: <80377ECBC5453840BA8C7155328B53770135AE5F@RTITMBSV03.realtek.com.tw> References: <1455807427-3177-1-git-send-email-hau@realtek.com> <20160218203516.GA18173@electric-eye.fr.zoreil.com> In-Reply-To: <20160218203516.GA18173@electric-eye.fr.zoreil.com> Accept-Language: zh-TW, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.21.177.156] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Chunhao Lin : > [...] > > I add checking driver's pm runtime status in rtl8169_get_stats64() to fix > > this issue. > > Would you consider taking the device out of suspended mode during > rtl8169_get_stats64 to prevent outdated stats ? > When in runtime suspend, it mean there is no traffic on NIC, so I did not wake the device during rtl8169_get_stats64(). Maybe we can update tally counter before entering runtime suspend mode. ------Please consider the environment before printing this e-mail.