From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932710AbcBWH5a (ORCPT <rfc822;w@1wt.eu>);
	Tue, 23 Feb 2016 02:57:30 -0500
Received: from rtits2.realtek.com ([60.250.210.242]:34278 "EHLO
	rtits2.realtek.com.tw" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S932326AbcBWH51 convert rfc822-to-8bit (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 23 Feb 2016 02:57:27 -0500
Authenticated-By: 
From: Hau <hau@realtek.com>
To: Francois Romieu <romieu@fr.zoreil.com>
CC: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        nic_swsd <nic_swsd@realtek.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH net v2] r8169:fix "rtl_counters_cond == 1 (loop: 1000, delay: 10)" log spam.
Thread-Topic: [PATCH net v2] r8169:fix "rtl_counters_cond == 1 (loop: 1000,
 delay: 10)" log spam.
Thread-Index: AQHRbYMfLfNPRLhl0EuTH/kamDLJUZ84LAOAgAEXvYA=
Date: Tue, 23 Feb 2016 07:57:16 +0000
Message-ID: <80377ECBC5453840BA8C7155328B53770135FF33@RTITMBSV03.realtek.com.tw>
References: <1456153794-2028-1-git-send-email-hau@realtek.com>
 <20160222231301.GA17876@electric-eye.fr.zoreil.com>
In-Reply-To: <20160222231301.GA17876@electric-eye.fr.zoreil.com>
Accept-Language: zh-TW, en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [172.21.177.156]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> Nits:
> 
> - the tp->TxDescArray test provides the required synchronization: see
>   rtl8169_{open/close} and their pm_runtime_{get / put}.
> 
> - ioaddr is not really needed : tp->mmio_addr appears only once and it does
>   not mess the 72..80 cols limit.
> 
> - even if the device can only be automatically runtime suspended some time
>   after a link down event, you may address davem's point regarding stats
>   reliability and move rtl8169_rx_missed + rtl8169_update_counters after
>   rtl8169_net_suspend.

I will submit the new patch according to your advice.

Thanks.

Please consider the environment before printing this e-mail.