From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752757AbdBMOJA (ORCPT ); Mon, 13 Feb 2017 09:09:00 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:26176 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751313AbdBMOI7 (ORCPT ); Mon, 13 Feb 2017 09:08:59 -0500 Subject: Re: [PATCH v2 2/3] xen/privcmd: Add IOCTL_PRIVCMD_DM_OP To: Paul Durrant , "xen-devel@lists.xenproject.org" , "linux-kernel@vger.kernel.org" References: <1486736677-10953-1-git-send-email-paul.durrant@citrix.com> <1486736677-10953-3-git-send-email-paul.durrant@citrix.com> <2937e443-e83f-a8c4-674e-33a49d8d4ba1@oracle.com> <797fa92d018947299249bc92fa8511b9@AMSPEX02CL03.citrite.net> Cc: Juergen Gross From: Boris Ostrovsky Message-ID: <80386563-dbfb-f43b-10d7-942c7ee6e544@oracle.com> Date: Mon, 13 Feb 2017 09:08:41 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <797fa92d018947299249bc92fa8511b9@AMSPEX02CL03.citrite.net> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >> How about something like (with rather arbitrary values) >> >> #define PRIVCMD_DMOP_MAX_NUM_BUFFERS 16 >> #define PRIVCMD_DMOP_MAX_TOT_BUFFER_SZ 4096 >> >> and make them part of the interface (i.e. put them into privcmd.h)? > > Given that the values are arbitrary, I think it may be better to make them module params. They can then at least be tweaked if privcmd becomes a problem with later dm_ops. Making them adjustable is a good thing but we still need default values. -boris