mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Shuah Khan <skhan@linuxfoundation.org>
To: "T.J. Mercier" <tjmercier@google.com>,
	Christian Brauner <brauner@kernel.org>,
	Shuah Khan <shuah@kernel.org>,
	Alexander Mikhalitsyn <alexander@mihalicyn.com>
Cc: linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
	Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH] tests/pid_namespace: Add missing sys/mount.h
Date: Tue, 8 Apr 2025 16:48:01 -0600	[thread overview]
Message-ID: <803bf3ec-08ff-49c5-8bf1-1fa27f2477e7@linuxfoundation.org> (raw)
In-Reply-To: <20250407225953.1540476-1-tjmercier@google.com>

On 4/7/25 16:59, T.J. Mercier wrote:
> pid_max.c: In function ‘pid_max_cb’:
> pid_max.c:42:15: error: implicit declaration of function ‘mount’
>                                         [-Wimplicit-function-declaration]
>     42 |         ret = mount("", "/", NULL, MS_PRIVATE | MS_REC, 0);
>        |               ^~~~~
> pid_max.c:42:36: error: ‘MS_PRIVATE’ undeclared (first use in this
>                                    function); did you mean ‘MAP_PRIVATE’?
>     42 |         ret = mount("", "/", NULL, MS_PRIVATE | MS_REC, 0);
>        |                                    ^~~~~~~~~~
>        |                                    MAP_PRIVATE
> pid_max.c:42:49: error: ‘MS_REC’ undeclared (first use in this function)
>     42 |         ret = mount("", "/", NULL, MS_PRIVATE | MS_REC, 0);
>        |                                                 ^~~~~~
> pid_max.c:48:9: error: implicit declaration of function ‘umount2’; did
>                 you mean ‘SYS_umount2’? [-Wimplicit-function-declaration]
>     48 |         umount2("/proc", MNT_DETACH);
>        |         ^~~~~~~
>        |         SYS_umount2
> pid_max.c:48:26: error: ‘MNT_DETACH’ undeclared (first use in this
>                                                                 function)
>     48 |         umount2("/proc", MNT_DETACH);
> 
> Fixes: 615ab43b838b ("tests/pid_namespace: add pid_max tests")
> Signed-off-by: T.J. Mercier <tjmercier@google.com>

Change the short log to include the subsystem. Send v2 with this
change.

selftests: pid_namespace: Add missing sys/mount.h

thanks,
-- Shuah

  reply	other threads:[~2025-04-08 22:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-07 22:59 T.J. Mercier
2025-04-08 22:48 ` Shuah Khan [this message]
2025-04-08 23:10   ` T.J. Mercier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=803bf3ec-08ff-49c5-8bf1-1fa27f2477e7@linuxfoundation.org \
    --to=skhan@linuxfoundation.org \
    --cc=alexander@mihalicyn.com \
    --cc=brauner@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=shuah@kernel.org \
    --cc=tjmercier@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®