From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02A78C4332F for ; Thu, 8 Dec 2022 06:11:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229655AbiLHGLF (ORCPT ); Thu, 8 Dec 2022 01:11:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52122 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229546AbiLHGLC (ORCPT ); Thu, 8 Dec 2022 01:11:02 -0500 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A51FA99F17 for ; Wed, 7 Dec 2022 22:11:00 -0800 (PST) Received: from kwepemm600017.china.huawei.com (unknown [172.30.72.56]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4NSNzg4g81zmWLC; Thu, 8 Dec 2022 14:10:07 +0800 (CST) Received: from [10.174.176.131] (10.174.176.131) by kwepemm600017.china.huawei.com (7.193.23.234) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 8 Dec 2022 14:10:57 +0800 Message-ID: <803c31e1-5e33-2a96-835c-420815a6e7a5@huawei.com> Date: Thu, 8 Dec 2022 14:10:57 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.1.2 Subject: Re: [PATCH] ASoC: rockchip: spdif: Add missing clk_disable_unprepare() in rockchip_pdm_runtime_resume() To: Mark Brown CC: , , , , , , , , References: <20221205024317.2422223-1-wangjingjin1@huawei.com> From: "Wangjingjin(KERNEL)" In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.176.131] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To kwepemm600017.china.huawei.com (7.193.23.234) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Right,will fix in v2 Thanks for review. 在 2022/12/7 21:58, Mark Brown 写道: > On Mon, Dec 05, 2022 at 10:43:17AM +0800, Wang Jingjin wrote: >> The clk_disable_unprepare() should be called in the error handling of >> rockchip_pdm_runtime_resume(). >> >> Fixes: fc05a5b22253 ("ASoC: rockchip: add support for pdm controller") >> Signed-off-by: Wang Jingjin >> --- >> sound/soc/rockchip/rockchip_pdm.c | 1 + >> 1 file changed, 1 insertion(+) > > The subject line says this is a fix for the S/PDIF driver but the patch > is for the PDM driver and I see you sent a separate fix for the PDM > driver.