From: Markus Elfring <Markus.Elfring@web.de>
To: linuxppc-dev@lists.ozlabs.org,
Kumar Gala <galak@kernel.crashing.org>,
Alexandre Bounine <alexandre.bounine@idt.com>,
Christophe Leroy <christophe.leroy@csgroup.eu>,
Jin Qing <b24347@freescale.com>, Li Yang <leoli@freescale.com>,
Liu Gang <Gang.Liu@freescale.com>,
Madhavan Srinivasan <maddy@linux.ibm.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Nicholas Piggin <npiggin@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
Subject: [bug report] powerpc/fsl_rio: Missing of_node_put() calls in fsl_rio_setup()
Date: Mon, 15 Sep 2025 14:52:42 +0200 [thread overview]
Message-ID: <80453b77-01ca-4fff-8a5a-deed4203be0f@web.de> (raw)
Hello,
Another script for the semantic patch language (Coocinelle software) pointed
details out also according to the implementation of the function “fsl_rio_setup”
for further development considerations.
https://elixir.bootlin.com/linux/v6.17-rc5/source/arch/powerpc/sysdev/fsl_rio.c#L439-L731
https://lore.kernel.org/cocci/504107f9-09eb-47fe-96ea-53e375b17eac@web.de/
https://sympa.inria.fr/sympa/arc/cocci/2025-09/msg00023.html
* I got the impression then that the function “of_node_put” should be called
in more cases here.
* How do you think about to avoid a bit of duplicate source code
by another update step?
* Further implementation details can be improved.
Regards,
Markus
reply other threads:[~2025-09-15 12:53 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=80453b77-01ca-4fff-8a5a-deed4203be0f@web.de \
--to=markus.elfring@web.de \
--cc=Gang.Liu@freescale.com \
--cc=alexandre.bounine@idt.com \
--cc=b24347@freescale.com \
--cc=christophe.leroy@csgroup.eu \
--cc=galak@kernel.crashing.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=leoli@freescale.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.ibm.com \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®