From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936447AbcIRV1p convert rfc822-to-8bit (ORCPT ); Sun, 18 Sep 2016 17:27:45 -0400 Received: from mga07.intel.com ([134.134.136.100]:49401 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935439AbcIRV1f (ORCPT ); Sun, 18 Sep 2016 17:27:35 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,359,1470726000"; d="scan'208";a="1042313593" From: "Dilger, Andreas" To: Nayeemahmed Badebade CC: Greg KH , "Drokin, Oleg" , James Simmons , "Lustre Development List" , "devel@driverdev.osuosl.org" , "Linux Kernel Mailing List" Subject: Re: [PATCH v2] staging: lustre: lustre/ldlm: Fixed sparse warnings Thread-Topic: [PATCH v2] staging: lustre: lustre/ldlm: Fixed sparse warnings Thread-Index: AQHSEfIxRJmg01zPQkK+du/PMsJE0qCAOGAA Date: Sun, 18 Sep 2016 21:27:30 +0000 Message-ID: <804AE8F8-BF12-4847-9AAD-B652A0BFF288@intel.com> References: <1474233499-11369-1-git-send-email-itachi.opsrc@gmail.com> In-Reply-To: <1474233499-11369-1-git-send-email-itachi.opsrc@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.252.26.92] Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > On Sep 18, 2016, at 23:18, Nayeemahmed Badebade wrote: > > Added __acquires / __releases sparse locking annotations > to lock_res_and_lock() and unlock_res_and_lock() functions > in l_lock.c, to fix below sparse warnings: > > l_lock.c:47:22: warning: context imbalance in 'lock_res_and_lock' - wrong count at exit > l_lock.c:61:6: warning: context imbalance in 'unlock_res_and_lock' - unexpected unlock > > Signed-off-by: Nayeemahmed Badebade Reviewed-by: Andreas Dilger > --- > > Changes in v2: > * Corrected sparse annotations for the lock > lock->l_resource->lr_lock > > drivers/staging/lustre/lustre/ldlm/l_lock.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/staging/lustre/lustre/ldlm/l_lock.c b/drivers/staging/lustre/lustre/ldlm/l_lock.c > index ea8840c..3845f38 100644 > --- a/drivers/staging/lustre/lustre/ldlm/l_lock.c > +++ b/drivers/staging/lustre/lustre/ldlm/l_lock.c > @@ -45,6 +45,8 @@ > * being an atomic operation. > */ > struct ldlm_resource *lock_res_and_lock(struct ldlm_lock *lock) > + __acquires(&lock->l_lock) > + __acquires(&lock->l_resource->lr_lock) > { > spin_lock(&lock->l_lock); > > @@ -59,6 +61,8 @@ struct ldlm_resource *lock_res_and_lock(struct ldlm_lock *lock) > * Unlock a lock and its resource previously locked with lock_res_and_lock > */ > void unlock_res_and_lock(struct ldlm_lock *lock) > + __releases(&lock->l_resource->lr_lock) > + __releases(&lock->l_lock) > { > /* on server-side resource of lock doesn't change */ > ldlm_clear_res_locked(lock); > -- > 1.9.1 >