From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7DDF74F4021 for ; Thu, 1 Oct 2026 09:18:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790846331; cv=none; b=nnBD7dFufKKi3/jw6dJAyGqpspnDcKfHHaUCHrRXAmqAbnz2sKTtSLAOVvA0g5jQ1tMmciE1HwxfC/KI10QjIwIElHW9m2DmYPiqUz6uiCKJKIU9k1eAPhM3EsLsOCLSbylL4ZPhQkHEssrOXHtUbRQlY1oqW5FxTgr0ZQz7Wbc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790846331; c=relaxed/simple; bh=JBnMyusVHVvC2aoo0+BM3BndoISvY4x9bprjjSPUysQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=jUnZjaLRllHOjHOrX8FGk0ibN6WZjygk6Emf/IvsoxhB0T9xhjuHFLi8sMRpZazc4hJP3lQN3LGLUBRoQtO8M9UUF68ZJnJxsNG51kEE4sqMoo5VEYVOMwTRmbgviDhM9lX8jxmNk20Q0m00JWzkx2+QaW3oJIA56srM/VvtU7g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=YryeaWqR; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=UjfYmEk2; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="YryeaWqR"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="UjfYmEk2" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1790846328; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=taG+MN3du7wj7jcNpPA84ZR57hK9GIPZJrpMAEYpafc=; b=YryeaWqR/fuvScjvAWdFyyRvewR0QnbyF2Z90VxUiucJGl1y5hyTs3OIwww6Xp4rMdBBHY ZlxUxj3qO+if3IihaQ4/c7pWj+JGdMnqacdxj5HFnQ9X/OUd8fsAKwK/TrQkUts7ezzq62 ap2gETvIR/1V8MOUEBRHQI3jzSbVk88= Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-686-uW9I11kHNGa5vC90B-2naw-1; Thu, 01 Oct 2026 05:18:47 -0400 X-MC-Unique: uW9I11kHNGa5vC90B-2naw-1 X-Mimecast-MFC-AGG-ID: uW9I11kHNGa5vC90B-2naw_1790846326 Received: by mail-ed1-f69.google.com with SMTP id 4fb4d7f45d1cf-6aaa4535b3bso7079859a12.3 for ; Thu, 01 Oct 2026 02:18:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1790846326; x=1791451126; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=taG+MN3du7wj7jcNpPA84ZR57hK9GIPZJrpMAEYpafc=; b=UjfYmEk2a6QTOTB7eeagwCcSv2WVwUG7ol56IwlNM8q48a1FgCOOXFJiSOTzKeOJbM pWmjEwnpvLJsgZLAwfhgS48HmqUcecuInmYeA0kbJSooDjnqAsud1NBeuNPyNSnxpzF7 uk0XYd32k/Dsk42bgQHCokOtHrJijE5aCkh7gVZ+cBtuEteVxlluYKpRGYSSlw9/H+Xc U1k2O2NP4jZOhjMzGg9cB5ft/31NKRXaPZhgZKzKeqLY//NIS5jIzqnpP4jMcvyAd4pS T3+voC+N+d5avaJx1Es5RHtZGlfK3c21Dya9GWe+FLB+/6vLCKcQHqigKujnTFkMNNOm UREQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790846326; x=1791451126; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=taG+MN3du7wj7jcNpPA84ZR57hK9GIPZJrpMAEYpafc=; b=09LapXqJaYzEraWE7bFfg2rof6dKOJmxP2NnhrJ/xF4RwJuS0jytOFti/gvCcBUVdW lqOLeM3bpoksVqn7Efh22VONVb0xZtgKpvZUEAqjkCCfwDx10QHER+fJV4MZKJ2xfZ9P CRy0883jdRR6ttlhNej/g1axTreMJ32gAqaa1sqK5+p4xMj/geQC4aJQquYnaMBUvE73 2mZYxBFb0dmuMcJy0i/V6qeMJmbziKYd2oQc2JphpiZGGVV70BCx7znWvtMDtdr6fzDF HtCfM1Fc9Y1pcaujKn3wKc0sMDX3FN8zW69zruupt4A1QpJrCQr1YpQTc3R4RoExqX+Y JihQ== X-Forwarded-Encrypted: i=1; AKwUvBwRsWIeUU8oGKUHJXt+uHwQr+W4lg0zVCZY5505ozAlSl0JBNxM4eBAIa/bccngWav/L43ss8zMpQ6M5yk=@vger.kernel.org X-Gm-Message-State: AFq9FYLx3ZkPwSuNwPaL26PIeq6fhcNE+W0ZXiMXO+UzirdNJKQoDH30 jHtxPmX+m2oIySkfAs8vnBPMm4xZ51FhI9fnm/xy/EwfFFdW48U1BP3XTPOzBz5peenRC/epInp Y0ZDeCCNhAyhXEjoQKEVbJBBw7Wr3QNnC0SRilEiGSr2wY1kbOxEJAU4C0jdEoZNOyg== X-Gm-Gg: AYBFou1u5HUmatJjoQzxnl6QaNhiTuR6hA2Bqb7AsHzIqLlW8M94+ObME1QH2WPaq1H Ouw7smB/LJp6/gP6Yc5LdLpGlk7bl1FF4dXCAyCzQmw2Vp8frRF6p4gVpDqI/sBNVINWZVLq9c6 /qx/5oKNNJen34mTbSbmR7eN13TUB3hgBpeAk8v4gyW2s8OktIVEJfm42pkmiBjlp3Re0ZFfM6r AqonoJ5MZTKRYvUvXzL8dAOTGqJnUR+JqtHpDINDhhWKoUSNLI17s2oZb+YBTjP+cVxYQMO3XhW xJzhcSqjuTlb3V8KLZZmxRGs0SWhepwL5goIXezAGzs2wwequMDV3YmUqZ4VG0tswCU+YUkiCu0 7qS3DVFuFypjQnSxOE1FsO7bVpaMiGy0vVqMA+3qucFH9cF6SwMAKJCT2CGxOHOQxrUiXxBCKMA == X-Received: by 2002:a05:6402:20d3:10b0:6ae:19c2:bae8 with SMTP id 4fb4d7f45d1cf-6ae19c2c1e8mr2528473a12.26.1790846326291; Thu, 01 Oct 2026 02:18:46 -0700 (PDT) X-Received: by 2002:a05:6402:20d3:10b0:6ae:19c2:bae8 with SMTP id 4fb4d7f45d1cf-6ae19c2c1e8mr2528460a12.26.1790846325893; Thu, 01 Oct 2026 02:18:45 -0700 (PDT) Received: from [192.168.188.234] (ip232-47-231-195.pool-bba.aruba.it. [195.231.47.232]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6ae5ca64e84sm721879a12.21.2026.10.01.02.18.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 01 Oct 2026 02:18:45 -0700 (PDT) Message-ID: <804cd85f-21d0-4fd9-9e53-cdcbfed27e9f@redhat.com> Date: Thu, 1 Oct 2026 11:18:44 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net 0/2] rxrpc: RACK-TLP fixes To: David Howells , netdev@vger.kernel.org Cc: Marc Dionne , Jakub Kicinski , "David S. Miller" , Eric Dumazet , Simon Horman , linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260925191520.2206700-1-dhowells@redhat.com> Content-Language: en-US From: Paolo Abeni In-Reply-To: <20260925191520.2206700-1-dhowells@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 9/25/26 21:15, David Howells wrote: > Here are some fixes for AF_RXRPC's RACK-TLP implementation. It's split > into two patches: the first just fixes the RFC number in comments but has > no actual code changes; the second does the actual fixing, including: > > - Making the in/exiting fast/RTO recovery flags available to RACK-TLP code > after the Reorder timer expires. > > - Arming the RTO timer if no other timer is running and there is unacked > data. > > - Initialising the TLP state in the correct place. > > - Not resetting the xmit timestamp when marking a packet lost. > > - Correctly checking the flight size. > > - Correctly tracking the number of packets in the Tx window that have been > re-sent and thus correctly estimating the flight size. I'm not sure if the sashiko feedback is worth addressing, or could be a follow-up. Also Linus is pushing back quite a bit on fixes this late in the cycle; we are trying to defer things to 'next', where appropriate. I think patch 1/2 will not pass Linus' filter, and possibly even patch 2/2 WDYT about targeting net-next here? If sashiko is deferrable, no need to repost. /P