From: Su Hui <suhui@nfschina.com>
To: Dan Carpenter <dan.carpenter@linaro.org>
Cc: Jan Harkes <jaharkes@cs.cmu.edu>,
coda@cs.cmu.edu, codalist@coda.cs.cmu.edu,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] coda: return -EFAULT if copy fails
Date: Tue, 16 May 2023 09:35:37 +0800 [thread overview]
Message-ID: <804e0736-ca51-39a2-b045-adafa9646c01@nfschina.com> (raw)
In-Reply-To: <3e92c08d-9c0d-4fcd-bf15-0fbcac3be26a@kili.mountain>
On 2023/5/15 15:35, Dan Carpenter wrote:
> On Mon, May 15, 2023 at 02:19:23PM +0800, Su Hui wrote:
>> The copy_to/from_user() functions should return -EFAULT instead of -EINVAL.
>>
>> Signed-off-by: Su Hui <suhui@nfschina.com>
>> ---
> Could you add a Fixes tag?
Hi,
This doesn't seem like a bug.
So I think Fixes tag should not be used here.
Thanks for your reply!
Su Hui
> regards,
> dan carpenter
>
next prev parent reply other threads:[~2023-05-16 1:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-15 6:19 Su Hui
2023-05-15 7:35 ` Dan Carpenter
2023-05-16 1:35 ` Su Hui [this message]
2023-05-15 17:15 ` Christophe JAILLET
[not found] <574ad370-cb3a-76db-ca8f-4203d42cc0fc@nfschina.com>
2023-05-16 1:17 ` Su Hui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=804e0736-ca51-39a2-b045-adafa9646c01@nfschina.com \
--to=suhui@nfschina.com \
--cc=coda@cs.cmu.edu \
--cc=codalist@coda.cs.cmu.edu \
--cc=dan.carpenter@linaro.org \
--cc=jaharkes@cs.cmu.edu \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®