From: Juergen Gross <jgross@suse.com>
To: Wentao Liang <vulab@iscas.ac.cn>, boris.ostrovsky@oracle.com
Cc: linux-kernel@vger.kernel.org, oleksandr_andrushchenko@epam.com,
oleksandr_tyshchenko@epam.com, sstabellini@kernel.org,
xen-devel@lists.xenproject.org, stable@vger.kernel.org
Subject: Re: [PATCH] xen/gntdev: Fix gntdev_dmabuf ref leak in dmabuf_exp_wait_released()
Date: Fri, 9 Oct 2026 10:15:40 +0200 [thread overview]
Message-ID: <8054e545-149d-48cc-9e2d-5a3cd3bd662d@suse.com> (raw)
In-Reply-To: <20260916170956.2086505-1-vulab@iscas.ac.cn>
[-- Attachment #1.1.1: Type: text/plain, Size: 830 bytes --]
On 16.09.26 19:09, Wentao Liang wrote:
> dmabuf_exp_wait_released() takes a reference on the exported
> gntdev_dmabuf with dmabuf_exp_wait_obj_get_dmabuf() and passes it to
> dmabuf_exp_wait_obj_new(), which drops that reference after adding the
> wait object to the wait list. When the wait object allocation fails,
> dmabuf_exp_wait_obj_new() returns ERR_PTR(-ENOMEM) early and the
> reference is never dropped, leaking a reference to the exported
> gntdev_dmabuf.
>
> Drop the reference on the allocation failure path so the reference is
> consumed whether the wait object is created or not.
>
> Fixes: 932d6562179e ("xen/gntdev: Add initial support for dma-buf UAPI")
> Cc: stable@vger.kernel.org
> Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
Reviewed-by: Juergen Gross <jgross@suse.com>
Juergen
[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 3743 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]
prev parent reply other threads:[~2026-10-09 8:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-16 17:09 Wentao Liang
2026-10-09 8:15 ` Juergen Gross [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8054e545-149d-48cc-9e2d-5a3cd3bd662d@suse.com \
--to=jgross@suse.com \
--cc=boris.ostrovsky@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oleksandr_andrushchenko@epam.com \
--cc=oleksandr_tyshchenko@epam.com \
--cc=sstabellini@kernel.org \
--cc=stable@vger.kernel.org \
--cc=vulab@iscas.ac.cn \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®