From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E10271DE2D8 for ; Thu, 19 Mar 2026 03:46:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773891996; cv=none; b=VlPKOLMTGakT2eLLKqLhNaIq7Kaj6pxtNYucg2dVjpLIcL1L4a0T7+N9iTuoqZWxk6fanpKfFuotbMVMY4QQWLFNnXtKTLimG3DIEMauk26zf1+glQ8Er+6JfUOmvUyvgLTo/lYfgORVaoo598W75TjbjulwA/Kz+5RR8tj6KMo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773891996; c=relaxed/simple; bh=730EHBuLk5bCeTw0u2oW5lqxojn+rPic07IRe8GT/80=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Y/EHxqf9egN5x6b0QludP74hmUcH3RUYuU5yaM67wqOcaAOYepQxyf0daqO/5ViYXGpHGlTPlDZhgkuHPN61TGpxNCCYm+diRY4/RKDDYiWqMcrlM1iccpQ8bbFyXMrwtYNzfOoF5F+Qk16viT5CpLkC5ks+TljXp0PKh/r/9Xs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Xf8pT9Gj; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Yxs+fvKY; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Xf8pT9Gj"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Yxs+fvKY" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62J0D1F2914345 for ; Thu, 19 Mar 2026 03:46:34 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 4b3s3EAjr8009h48cjzBmOUcZa2ExsAEz1rsedC2Zbw=; b=Xf8pT9GjFFs40JBQ 1uWNrrmdHG+ObQKYIuvorpoNna53OnBXqkCnHAKj+T7v0OI1rdEuxCYbcvlbP2dF 7S0FPpto+n1WX/Izlqy6IqBxrWYmyKRIj/YaWqja+zvyvhShuCpQC2mQDqtU/zmt mbAW/M2BPM8m2tAUsO7cHF5NLkrYwh/9QxTMeC6BehbQTqNBoD17KaCT/eVD1sWU 4MfrmwgtUCHXDb8mxk0Zjk5NLbXL4elYTH6lqSw9fDZV8mpjFOyqx/Eqruo4B4cU dPt51WcYtASbVMFMmoh1jUPhQVhSbz/sDSMnIYkhtmKqjrvdtwwAW0IjFb3MlmnG 2KDi0A== Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cytxyty98-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 19 Mar 2026 03:46:33 +0000 (GMT) Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-358e95e81aeso4388883a91.0 for ; Wed, 18 Mar 2026 20:46:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773891993; x=1774496793; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=4b3s3EAjr8009h48cjzBmOUcZa2ExsAEz1rsedC2Zbw=; b=Yxs+fvKYRfI5EVfaYe3F949hxsBRK6MDbUIBVqlBVQ7cxGmNT69N4QDtTb/bOnppO7 ulhkN6aL2lYk3VsuEygMhRqDun4D2pX4ip3NyRrKmFtVCHE6Rmr/U93LVxdXS779Uy1c FsSQVxsmBh2l4wHmRP8yGKt9MsfDAUWXDjtxrvo3x/RLr+rw+2X5k5lxGwwQl0YtTwj0 1+go8FGqdX9cT8suR73DHZJ1zY9iDQKwCzoQrxvebC8Lea++w3C+l05mAeSPvcD+kVxN ZH6Btp+Fi0HnVuF9Wh7wEEgb+8y7wNT/hllb4VVUkyvRQjGxbYlOd12LKyrbmKZXWxL+ 7r3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773891993; x=1774496793; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=4b3s3EAjr8009h48cjzBmOUcZa2ExsAEz1rsedC2Zbw=; b=k4OjeKYvbuo/CFzpfJ7Inv0oSDGSqqs6OX0b5lr4t1q++S090rkGWtq3vosXEmY8Kx U8NZrYEWDEMFG6McWY/qebkWmX1d67o9/80GNvT4MtZvvC7NcJH6NARD0oFMapX/fZvS j9Fj5VACg4b3BNnun2O1LPkpXlcfydNfqao0rNG2M46xsZw6a2juBu/HlBsAuhhvcww6 4NREad1KXuONrUV0THG8BbkIS1VVJlpg1Qg7PA7ENkIHCgTXwJB9aBhWM2w3/Hf+r+5x wzvsm1Wa3tGc0l/6nTqtQFN+1r3T04c4UdKvCWdaVB2DfBTyW1Gi8BMSRCicgtqtEkpZ VkTQ== X-Forwarded-Encrypted: i=1; AJvYcCVmR0KHifbDbO2JqKFzV1r4ix/jDwBllas5tp/N087GNrClhD/snYJNk/TrGYiCVxRyLKk3lUzN+z2VUJo=@vger.kernel.org X-Gm-Message-State: AOJu0YwbXAL7vr3f+TfwHcphvDBWQVRAELlWU2JUwBSfPd/2cG91rlvm GkiP2lIgEb1358tvoLUY4zRmgC9XM+2lazcMsBu+dSvsy2BzUzfEz+f9h9PC7DtIcuUsq62gzyt 0T8+jqWPfUGBxvS7l/FfMhD/S0tyXXFcRQa6Flgo0iVaKuAB3sIk89TptoRB6AmdqsrYJdgbzyn Q= X-Gm-Gg: ATEYQzxEyOKwL34O5ViR2/LBmp55TF93VlWdMOEZtroLtzI9oxUk5lQ9jpzjtq15+h6 ysBReqqCQmG2XpGFb3WaZZNrT1peGwgzAtKLYQVbZkFTNYrDm7mMh/qkM8aQZXPBJspZn3fVBHt kQrRcFr7r/52RzMp2BnNbFoPjkZMqwacsDvpydFxcC/XJWLTCM55tmLpDEK07olI/sOr5fDgvah 2aU0VKhXh0ASPB31Wq/E9ONLD/44pPEdXteXsSh+hQWril/C1dd59YQC/YajhOgkSVhuZG22oHF gwc/pvLF9M86FThWAy3cfn6u6y9dTWEUniPcuUPR0IHPa424MyuHeOnYRGF8Z2aTYnr0UynE/un B2GEtqmvAxrnf1jpEk+dHF88gnp3fpWiweVZcp05J62l9mPVI+a1RNGSJwAHegm2c0k0= X-Received: by 2002:a05:6a20:258e:b0:39b:9644:6e99 with SMTP id adf61e73a8af0-39b99fc2baemr5217329637.43.1773891992952; Wed, 18 Mar 2026 20:46:32 -0700 (PDT) X-Received: by 2002:a05:6a20:258e:b0:39b:9644:6e99 with SMTP id adf61e73a8af0-39b99fc2baemr5217316637.43.1773891992438; Wed, 18 Mar 2026 20:46:32 -0700 (PDT) Received: from [10.152.204.0] ([202.46.23.19]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c741e543579sm3889526a12.16.2026.03.18.20.46.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 Mar 2026 20:46:32 -0700 (PDT) Message-ID: <8056cb5f-cdde-4890-b8cf-3b37d1c3483f@oss.qualcomm.com> Date: Thu, 19 Mar 2026 09:16:28 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH ath-current] wifi: ath12k: prepare REO update element only for primary link To: Baochen Qiang , Jeff Johnson Cc: linux-wireless@vger.kernel.org, ath12k@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260210-ath12k-rxtid-double-free-v1-1-8b523fb2886d@oss.qualcomm.com> Content-Language: en-US From: Vasanthakumar Thiagarajan In-Reply-To: <20260210-ath12k-rxtid-double-free-v1-1-8b523fb2886d@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: D1AcNy81KylWx1T8o9fXqnOr5RDMU3D7 X-Authority-Analysis: v=2.4 cv=FKAWBuos c=1 sm=1 tr=0 ts=69bb719a cx=c_pps a=RP+M6JBNLl+fLTcSJhASfg==:117 a=j4ogTh8yFefVWWEFDRgCtg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=v1BbFoewtlT1sTZsXLUA:9 a=QEXdDO2ut3YA:10 a=iS9zxrgQBfv6-_F4QbHw:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzE5MDAyNiBTYWx0ZWRfX33Ey+ShCZVfb 1NOkxacnnYEjQ83Mc2beB677tDTC6Xh73C3bVNcvedElfs1kuA6Kgd3dsdY0+XOo/TKVaeUYsvi Ff3LK7RCGvQuF5JlxyIGyta96P6gyAeJ21TaJtjL+3FTkBjm6baJQ4+QiEsJHfwRHlLS20cZCJx i0rjICKTvesvVPg3oSMFXzipQ5l+AcSo6tdWxrRfxikCfxzgZAuEx4F/QkGkw0n4vVE6SE9iTBi bCPZzjJpx3dIwQXe/B5f3kARrMG8kIylo+40KdzjaVubHJrArqjRGv3Q8NadURYSmYuTRK/rcLZ zdlFMRHtZgafoLfIdRLbnsPqbBSU55ZucfCIqNCSEsR3ZRO6EXeJDNU2BX9xkOyZ72L12wr9Tbu +e3O0cnl6PSyOBukKSBOiaQWJgX/mIobMjZoYc5kHSVbmUB9aG1PAEtdj6n2mgqqHJM0dPz6Nld H5241K5GgPaRUCeb4Sg== X-Proofpoint-ORIG-GUID: D1AcNy81KylWx1T8o9fXqnOr5RDMU3D7 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-18_02,2026-03-17_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 adultscore=0 bulkscore=0 clxscore=1015 spamscore=0 lowpriorityscore=0 impostorscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603190026 On 2/10/2026 8:37 AM, Baochen Qiang wrote: > Commit [1] introduces dp->reo_cmd_update_rx_queue_list for the purpose > of tracking all pending REO queue flush commands. The helper > ath12k_dp_prepare_reo_update_elem() allocates an element and populates > it with REO queue information, then add it to the list. The element would > be helpful during clean up stage to finally unmap/free the corresponding > REO queue buffer. > > In MLO scenarios with more than one links, for non dp_primary_link_only > chips like WCN7850, that helper is called for each link peer. This > results in multiple elements added to the list but all of them pointing > to the same REO queue buffer. Consequently the same buffer gets > unmap/freed multiple times: > > BUG kmalloc-2k (Tainted: G B W O ): Object already free > ----------------------------------------------------------------------------- > Allocated in ath12k_wifi7_dp_rx_assign_reoq+0xce/0x280 [ath12k_wifi7] age=7436 cpu=10 pid=16130 > __kmalloc_noprof > ath12k_wifi7_dp_rx_assign_reoq > ath12k_dp_rx_peer_tid_setup > ath12k_dp_peer_setup > ath12k_mac_station_add > ath12k_mac_op_sta_state > [...] > Freed in ath12k_dp_rx_tid_cleanup.part.0+0x25/0x40 [ath12k] age=1 cpu=27 pid=16137 > kfree > ath12k_dp_rx_tid_cleanup.part.0 > ath12k_dp_rx_reo_cmd_list_cleanup > ath12k_dp_cmn_device_deinit > ath12k_core_stop > ath12k_core_hw_group_cleanup > ath12k_pci_remove > > Fix this by allowing list addition for primary link only. Note > dp_primary_link_only chips like QCN9274 are not affected by this change, > because that's what they were doing in the first place. > > Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.1.c5-00302-QCAHMTSWPL_V1.0_V2.0_SILICONZ-1.115823.3 > > Fixes: 3bf2e57e7d6c ("wifi: ath12k: Add Retry Mechanism for REO RX Queue Update Failures") # [1] > Closes: https://bugzilla.kernel.org/show_bug.cgi?id=221011 > Signed-off-by: Baochen Qiang Vasanthakumar Thiagarajan