From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32F21C2D0D1 for ; Mon, 6 Jan 2020 10:18:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 04AEC2072C for ; Mon, 6 Jan 2020 10:18:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="Js15L4kk" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726411AbgAFKSV (ORCPT ); Mon, 6 Jan 2020 05:18:21 -0500 Received: from mail25.static.mailgun.info ([104.130.122.25]:49177 "EHLO mail25.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725446AbgAFKSU (ORCPT ); Mon, 6 Jan 2020 05:18:20 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1578305900; h=Content-Transfer-Encoding: Content-Type: In-Reply-To: MIME-Version: Date: Message-ID: From: References: Cc: To: Subject: Sender; bh=1OHQW4/xD2XUS1jStNjnGNpG1EuF7f1TD2E/Qky6pv4=; b=Js15L4kkC/R+Ik5qGaRH2lcKG2ESrSJMvFljeGmI7D0v40rsanRjpiOX8BQQfHUGhhgByz3l SnsGnWC/R5rZoh9ORC2i/toLOI6H5cM2VEB2N4fZUTgPsbFyjdI3qVUMgqO6Kj9QyXEkX+sY Cyc/KLH+e3PEj1cyHq56fduSbDs= X-Mailgun-Sending-Ip: 104.130.122.25 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5e130965.7efd9b990848-smtp-out-n02; Mon, 06 Jan 2020 10:18:13 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id EA5E5C447A1; Mon, 6 Jan 2020 10:18:11 +0000 (UTC) Received: from [10.206.28.9] (blr-c-bdr-fw-01_GlobalNAT_AllZones-Outside.qualcomm.com [103.229.19.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: tdas) by smtp.codeaurora.org (Postfix) with ESMTPSA id 31D34C433CB; Mon, 6 Jan 2020 10:18:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 31D34C433CB Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=tdas@codeaurora.org Subject: Re: [PATCH v1 1/2] clk: qcom: rpmh: skip undefined clocks when registering To: Stephen Boyd , Michael Turquette Cc: David Brown , Rajendra Nayak , linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org References: <1577790048-18263-1-git-send-email-tdas@codeaurora.org> <1577790048-18263-2-git-send-email-tdas@codeaurora.org> <20200102005700.1EAAE20672@mail.kernel.org> From: Taniya Das Message-ID: <806299af-38fb-05e4-7fd5-9e2344a53f8d@codeaurora.org> Date: Mon, 6 Jan 2020 15:48:06 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.3.1 MIME-Version: 1.0 In-Reply-To: <20200102005700.1EAAE20672@mail.kernel.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Stephen, Thanks for your review comments. On 1/2/2020 6:26 AM, Stephen Boyd wrote: > Quoting Taniya Das (2019-12-31 03:00:47) >> diff --git a/drivers/clk/qcom/clk-rpmh.c b/drivers/clk/qcom/clk-rpmh.c >> index 7ed313a..05cbe6f 100644 >> --- a/drivers/clk/qcom/clk-rpmh.c >> +++ b/drivers/clk/qcom/clk-rpmh.c >> @@ -462,7 +464,8 @@ static int clk_rpmh_probe(struct platform_device *pdev) >> >> ret = devm_clk_hw_register(&pdev->dev, hw_clks[i]); >> if (ret) { >> - dev_err(&pdev->dev, "failed to register %s\n", name); >> + dev_err(&pdev->dev, "failed to register %s\n", >> + hw_clks[i]->init->name); > > After register clk_hw::init is NULL. This will probably oops. It would > be better to save off the name before registering. > Will take care in the next patch series. -- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation. --